Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use integer64 flag for Cray Fortran compiler #617

Merged
merged 5 commits into from
Apr 12, 2022

Conversation

ajaypanyala
Copy link
Contributor

Description
use default64 flag for Cray ftn compiler when BUILD_INDEX64 is ON.

Checklist

  • [ X] The documentation has been updated.
  • [X ] If the PR solves a specific issue, it is set to be closed on merge.

@ajaypanyala ajaypanyala changed the title use default64 flag for Cray Fortran compiler use integer64 flag for Cray Fortran compiler Sep 1, 2021
langou
langou previously approved these changes Sep 1, 2021
@ajaypanyala
Copy link
Contributor Author

@langou Could you please review the latest commit again, thanks!

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #617 (9c2380c) into master (1782d90) will not change coverage.
The diff coverage is n/a.

❗ Current head 9c2380c differs from pull request most recent head f3e8010. Consider uploading reports for the commit f3e8010 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #617   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1894     1894           
  Lines      184034   184021   -13     
=======================================
+ Misses     184034   184021   -13     
Impacted Files Coverage Δ
SRC/cgeqrf.f 0.00% <0.00%> (ø)
SRC/cgerqf.f 0.00% <0.00%> (ø)
SRC/dgeqrf.f 0.00% <0.00%> (ø)
SRC/dgerqf.f 0.00% <0.00%> (ø)
SRC/sgeqrf.f 0.00% <0.00%> (ø)
SRC/sgerqf.f 0.00% <0.00%> (ø)
SRC/zgeqrf.f 0.00% <0.00%> (ø)
SRC/zgerqf.f 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1782d90...f3e8010. Read the comment docs.

@weslleyspereira
Copy link
Collaborator

Hi @ajaypanyala. Could you please help resolving this conflict?
We accepted #624 that uses set(FORTRAN_ILP TRUE) instead of set(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fdefault-integer-8"). I am not sure if #624 is sufficient to enable default64 flag for Cray ftn compiler.

@ajaypanyala ajaypanyala mentioned this pull request Dec 14, 2021
2 tasks
@ajaypanyala
Copy link
Contributor Author

Hi @weslleyspereira I can update #617 to reflect my comment on #624. Please let me know If you want me to proceed with that.

@weslleyspereira
Copy link
Collaborator

Hi @weslleyspereira I can update #617 to reflect my comment on #624. Please let me know If you want me to proceed with that.

Oh, now I see the command set(CMAKE_Fortran_FLAGS ... ) was only moved (and not removed) in #617. I agree with your proposed changes. You can proceed with the modifications. Thanks!

@weslleyspereira weslleyspereira merged commit 5559978 into Reference-LAPACK:master Apr 12, 2022
@julielangou julielangou added this to the LAPACK 3.10.1 milestone Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants