Fix xGEQRF and xGERQF following thanks to @andreasvarga and @VasileSima4 #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langou
approved these changes
Nov 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1894 1894
Lines 184021 184034 +13
=======================================
- Misses 184021 184034 +13
Continue to review full report at Codecov.
|
Closed
weslleyspereira
added a commit
to weslleyspereira/lapack
that referenced
this pull request
Jul 14, 2022
weslleyspereira
added a commit
to weslleyspereira/lapack
that referenced
this pull request
Jul 18, 2022
weslleyspereira
added a commit
to weslleyspereira/lapack
that referenced
this pull request
Jul 18, 2022
weslleyspereira
added a commit
that referenced
this pull request
Jul 18, 2022
Fix the left-looking variant of geqrf following #638
angsch
pushed a commit
to angsch/lapack
that referenced
this pull request
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xGEQRF and xGERQF return wrong optimal dimension LWORK when M and N equals zero, respectively. This applies the fixes proposed by @andreasvarga and @VasileSima4 in #633.
Fix #633.