Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numerical tests for trevc3 #682

Merged
merged 3 commits into from
Mar 18, 2023
Merged

Add numerical tests for trevc3 #682

merged 3 commits into from
Mar 18, 2023

Conversation

angsch
Copy link
Collaborator

@angsch angsch commented Jun 20, 2022 •
edited
Loading

Description

Add some numerical tests for the so far completely untested trevc3

@angsch angsch marked this pull request as draft June 20, 2022 17:16
@thijssteel
Copy link
Collaborator

If i'm not mistaken, trevc3 is tested because it is a part of geev, and geev is thoroughly tested, so I wouldn't say that trevc3 is completely untested (correct me if i'm wrong). However, separate tests for subroutines are always welcome.

Is this perhaps an indication that you will use the skills you used to write #651 to improve trevc3?

@angsch
Add missing numerical tests for TREVC3
22d1721 
At least some tests, though there are still code paths
that are not covered
* input sizes defined in nep.in are small
* RWORK in [CZ]TREVC3 is de factor defined as N-vector
  from the input file and limits the blocked computation
@angsch
standardize style in laqr5
9f9295f
@angsch
Rewrite [ds]hgeqz to use FMA with Householder reflectors
0a6cd43
@angsch
Copy link
Collaborator Author

angsch commented Jul 6, 2022

@thijssteel Could you be so kind and have a look?
Your suggestion to write the application of the Householder reflectors in a consistent way should be complete now; and, while I was already on it, the change is applied to the generalized problem as well. As far as I see it, that's all occurrences.

trevc3 is tested because it is a part of geev, and geev is thoroughly tested

The tests cover at least one more case that is not covered by geev: The backtransform is done in the tests, no via the eigenvector computation routine. There are a few more improvements that can be done in trevc3, so more tests are indeed good. :-)

@angsch angsch marked this pull request as ready for review July 6, 2022 19:48
thijssteel
thijssteel approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@thijssteel thijssteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, sorry for the delay

@langou langou merged commit cfaa5ae into Reference-LAPACK:master Mar 18, 2023
@martin-frbg
Copy link
Collaborator

Just a late and general comment from me - wouldn't it make sense to update the PR title when a PR evolves to include a rewrite of the underlying algorithm in addition to the new tests ?

@thijssteel
Copy link
Collaborator

It's actually a rewrite of a different algorithm. And yes, an even better update would be to split the PR.

@angsch angsch deleted the trevc3 branch June 26, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langou langou langou approved these changes

@thijssteel thijssteel thijssteel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@angsch @thijssteel @martin-frbg @langou