Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I make a PR to implement meson builder support #42

Open
AtilaSaraiva opened this issue Oct 30, 2021 · 4 comments
Open

Can I make a PR to implement meson builder support #42

AtilaSaraiva opened this issue Oct 30, 2021 · 4 comments

Comments

@AtilaSaraiva
Copy link

Hello guys,

I know there is the CMake already in place, but I still want to implement support for the meson builder. That way I can wrap this github project as a subproject dependency on my repositories. That way, if the used doenst have it already installed on their machine, it will trigger the compilation. Since it uses ninja, it also may shorten the compilation time considerably.

Thx!

@zerothi
Copy link
Contributor

zerothi commented Dec 16, 2021

I think you should just make a PR ;)
All build-systems are orthogonal to each other, so this should be fine.

Note: I am not a maintainer here, so have no say in this.

@AtilaSaraiva
Copy link
Author

The thing is that I intend to make changes in file structure of the repository, so I'll not be able to maintain support for SCons development, but I intend to still use SCons for recipes (although everyone should be using python by now).

@zerothi
Copy link
Contributor

zerothi commented Dec 17, 2021

Hmm, I see. I don't think that would be appropriate... Which kind of changes?

@langou
Copy link
Contributor

langou commented Dec 17, 2021

On the LAPACK side of things, we had a discussion about this and we decided to remove the meson build. See: Reference-LAPACK/lapack#511
It is not my preference to add a meson build to ScaLAPACK for now. We can discuss about the merit. Please read the discussion related to the PR Reference-LAPACK/lapack#511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants