Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pointer macro to prevent integer oveflow #16

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

luszczek
Copy link
Contributor

An integer overflow occurs and causes segmentation fault
when 2D row/col index is linearized using 32-bit integers.
PBLAS Mptr() macro should be used instead.

This fix only fixes address calculations with row, column, and leading
dimension. There might be other places where an overflow occurs but
they may not matter for practical purposes because they would require
very large matrices or very long vectors within a single process.

An integer overflow occurs and causes segmentation fault
when 2D row/col index is linearized using 32-bit integers.
PBLAS Mptr() macro should be used instead.

This fix only fixes address calculations with row, column, and leading
dimension. There might be other places where an overflow occurs but
they may not matter for practical purposes because they would require
very large matrices or very long vectors within a single process.
@langou langou merged commit 0efeeb6 into Reference-ScaLAPACK:master Dec 23, 2019
@langou
Copy link
Contributor

langou commented Dec 23, 2019

Thanks @luszczek !

@julielangou julielangou added this to the 2.2 release milestone Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants