This repository has been archived by the owner on Jul 27, 2021. It is now read-only.
[MIRROR] [PORT] Emissivity Blockers #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Better glowing lights (#49454) * better glowy lights * phase 2 * some doc comments * working emissive blocking * flag so these rotate correctly * full brightness screens * doc comments and rename * better doc comments * stub overrides * better autodoc format * Update code/game/atoms_movable.dm Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com> * Update code/modules/lighting/emissive_blocker.dm Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com> * render target defines for all planes * update proc for emissive blocker Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com> * emissive blockers are now just an overlay (with kickass fucking graphs). FUCK YOU MAPTICK (#57934) currently emissive blockers are objects added to the vis_contents of every item. however mutable appearances as overlays can serve this role perfectly well and according to my tests should cause less maptick per item. for mobs mutable appearances dont work for reasons i dont understand so instead this adds the em_block object to overlays instead of vis_contents. these both use atom/movable/update_icon() now Co-authored-by: Rob Bailey <actioninja@gmail.com> Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com> Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: BeeStation/BeeStation-Hornet#3993
About The Pull Request
Includes:
tgstation/tgstation#49454
tgstation/tgstation#57934
Why It's Good For The Game
Emissivity is now clipped instead of showing over every single thing in the game.
Changelog
馃啈 actioninja, Kylerace
fix: Glowing overlays no longer render above everything, and mobs and items properly block them
/:cl: