Support Swift 4 #29
Support Swift 4 #29
Conversation
|
👍 looks like the right programming language |
Package.swift
Outdated
| name: "LambdaKit", | ||
| targets: ["LambdaKit"]), | ||
| ], | ||
| dependencies: [ |
There was a problem hiding this comment.
you should be able to omit this one
There was a problem hiding this comment.
There was a problem hiding this comment.
we can't omit because the file structure is not following the conventional layout. See the "path" parameter.
There was a problem hiding this comment.
Is there a new standard layout? Since this was the standard before I guess?
There was a problem hiding this comment.
IMO we should make it whatever the standard is if we can reduce all this nonsense
There was a problem hiding this comment.
lemme see what can be done.
There was a problem hiding this comment.
We shouldn't let this block our Swift 4 merge tho, so this is fine if this all works, but we should follow up
There was a problem hiding this comment.
yeah not going to make this a hard dependency.
dduan
force-pushed
the
swift-4.0
branch
8 times, most recently
from
d9d5a8c
to
4dfc894
Compare
Reorganized files so they fit SPM convention. Updated Package.swift format for 4.0 era.
We have to update Package.swift format in order to get the generated pbxproj to have
4.0as the value forSWIFT_VERSION.