User edits rebase #530
Merged
User edits rebase #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This forces the form to submit to /restrooms with POST. Normally, simple_form_for would submit to /restrooms/:id with PATCH if the restroom already exists, which results in invoking the update method on restroom controller.
Add edit_id to permitted params and add it as a hidden field in the form, which allows it to be submitted. The edit_id set in the 'new' method only affects the value of the field in the form, and not the edit_id for the @Restroom in the create method, since they refer to different objects.
Redirect to the original restroom that was edited. params[:id] is nil because the params here are the ones submitted with the form, and there isn't an id field in the form.
It was removed in 9b1437a ("update current scope") but I think that was an accident. We still need the script.
With migration.
User edit proposals - rebased on develop
This was referenced Nov 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase to fix the tests.