Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alt attributes to badges on the splash page for accessibility #560

Merged
merged 3 commits into from
Mar 7, 2019
Merged

Add alt attributes to badges on the splash page for accessibility #560

merged 3 commits into from
Mar 7, 2019

Conversation

DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented Feb 20, 2019 •
edited
Loading

Context

  • Adds alt text to badges on the homepage, for accessibility purposes.

Summary of Changes

  • Add alt text for these badges:
    • App Store link
    • Google Play link
    • Patreon link

Checklist

  • Tested Mobile Responsiveness
  • Added Unit Tests
  • CI Passes
  • Deploys to Heroku on test Correctly (Maintainers will handle)
  • Added Documentation (Service and Code when required)

Screenshots

Before

WAVE accessibility evaluation tool shows three errors relating to missing alt text on images within links.

After

WAVE accessibility evaluation tool now shows no errors. Three "features" are identified, namely images within links that have alt text.

@DeeDeeG
index.html.haml: Add image alt attributes
8c51951 
Helps with accessibility.
@DeeDeeG
splash page: Add translatable alt text to images
bf4575c 
helps with accessibility, and ensures we can translate
to multiple locales/languages.
@DeeDeeG
en/splash.en.yml: Better alt text for images
cbca87b
@DeeDeeG DeeDeeG changed the title Add image alt attributes translatable Add alt attributes to badges on the splash page for accessibility Feb 20, 2019
@DeeDeeG DeeDeeG mentioned this pull request Feb 20, 2019
Open
@DeeDeeG
Copy link
Contributor Author

DeeDeeG commented Mar 5, 2019

Hoping to merge this in the next couple of days.

@DeeDeeG DeeDeeG merged commit 6ca8a91 into RefugeRestrooms:develop Mar 7, 2019
@DeeDeeG DeeDeeG mentioned this pull request Oct 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@DeeDeeG