Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian texts not displayed correctly on Terminals when Monospace Font is ON + other text related issues. #11633

Closed
1 of 2 tasks
Singularia opened this issue Mar 22, 2023 · 4 comments
Assignees
Labels
Bug Something isn't working Code Programming task Localization

Comments

@Singularia
Copy link

Disclaimers

  • I have searched the issue tracker to check if the issue has already been reported.
  • My issue happened while using mods.

What happened?

Russian localisation lines and manually typed texts do not display correctly in the Terminal when the Monospace Font flag is enabled. When the game localisation is switched back to English, text lines will display correctly.

Examples below:

Manually typed message on top + modded "welcome" message on the bottom.

Monospace Font flag is disabled.
image

Monospace Font flag is enabled.
image

Another modded "welcome" message, Monospace Font flag is Disabled.
image

Another modded "welcome" message, Monospace Font flag is Enabled.
image

The same issue occurs when using vanilla localised text lines.

Vanilla `terminalwelcomemsg.kastrulldiary1` Welcome message

Monospace Font flag is Disabled.
image

Monospace Font flag is Enabled.
image


Reproduction steps

  1. Using Sub-Editor place two Terminals on any sub of choice.
  2. Terminal 1: In the Terminal's Welcome message use any existing vanilla text lines and enable Monospace Font.
  3. Terminal 2: In the Terminal's Welcome message use any existing vanilla text lines and leave Monospace Font setting disabled.
  4. In the Test mode (switching to English/Russian prior) observe difference in how text displays.

Bug prevalence

Happens every time I play

Version

v1.0.8.0

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

@Singularia
Copy link
Author

As to not pollute issue tracker I'll add additional text-related issues that I noticed when tested the main point of this ticket.

Additionally, it appears that if you type any predefined line from localisation file in the Sonar Beacon's message box then it will show them correctly on Sonar, but not in the message window itself.

Examples below are three Sonar beacons with different messages.

Sonar Beacon without any changes

Message window (EN-RU)
image
image

View from Sonar (EN-RU)
image
image

Sonar Beacon with modded localisation label

Message window (same line in the message window, regardless of language)
image

View from Sonar (EN-RU)
image
image

Sonar Beacon with vanilla localisation label

Message window (same line in the message window, regardless of language)
image

View from Sonar (EN-RU)
image
image

@Singularia Singularia changed the title Russian texts not displayed correctly on Terminals when Monospace Font is ON Russian texts not displayed correctly on Terminals when Monospace Font is ON + other text related issues. Mar 22, 2023
@Singularia
Copy link
Author

Singularia commented Mar 22, 2023

While adding localisation to some beacons from the Beacons Extended mod, i noticed that text is not localised if there are multiple lines merged using the Concatenation Component.

Example:
Simple test scheme:
N.B. Both Concatenation Components have one space as a separator.
image

Lines are:
[EN]

<label.shuttleloc>Trying to locate supply shuttle... Disantce:</label.shuttleloc>
<label.distaway>meters away</label.distaway>

[RU]

<label.shuttleloc>Поиск челнока снабжения... Расстояние:</label.shuttleloc>
<label.distaway>метров</label.distaway>

The end result should be:
[EN]
"Trying to locate supply shuttle... Disantce: 1914 meters away"
[RU]
"Поиск челнока снабжения... Расстояние: 1914 метров"

Instead, the end result is this:
image

@itchyOwl itchyOwl added Bug Something isn't working Code Programming task Localization labels Mar 28, 2023
@Regalis11 Regalis11 self-assigned this Mar 30, 2023
@Rokvach
Copy link
Collaborator

Rokvach commented Apr 11, 2023

Tested, working correctly. Closing.

@Rokvach Rokvach closed this as completed Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Code Programming task Localization
Projects
None yet
Development

No branches or pull requests

4 participants