Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding unused parameters behind VORB_UNUSED. #22

Open
MatthewJM96 opened this issue Aug 15, 2018 · 0 comments
Open

Hiding unused parameters behind VORB_UNUSED. #22

MatthewJM96 opened this issue Aug 15, 2018 · 0 comments

Comments

@MatthewJM96
Copy link
Member

In order to get compilation to issue fewer warnings without disabling the warnings themselves, we have hidden all unused parameters behind a macro "VORB_UNUSED". This is a temporary measure and we want to review each location VORB_UNUSED is used, and follow the sequence:

  1. Do we want to reimplement/revise the system in which the function resides?
    • If yes, do so or go to step 3.
  2. Is the parameter unused in all compilation and logic paths of the code?
    • If yes, make the parameter anonymous;
    • If no, mark the parameter with VORB_MAYBE_UNUSED;
    • In either case remove the VORB_USED tag.
  3. Find the next VORB_UNUSED-tagged parameter you want to tackle and go to step 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant