Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ConcurrentDictionary instead of lock #363

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Use ConcurrentDictionary instead of lock #363

merged 2 commits into from
Jun 16, 2021

Conversation

krajek
Copy link
Collaborator

@krajek krajek commented Jun 16, 2021

No description provided.

@krajek
Copy link
Collaborator Author

krajek commented Jun 16, 2021

I have checked our benchmark timings before and after the change. There was no difference.

@RehanSaeed RehanSaeed added enhancement Issues describing an enhancement or pull requests adding an enhancement. patch Pull requests requiring a patch version update according to semantic versioning. labels Jun 16, 2021
@RehanSaeed
Copy link
Owner

I think there would only be a difference in multi-threaded scenarios.

@RehanSaeed RehanSaeed merged commit aea4add into main Jun 16, 2021
@RehanSaeed RehanSaeed deleted the feature/concurrent-dictionary branch June 16, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. patch Pull requests requiring a patch version update according to semantic versioning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krajek @RehanSaeed