Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .NET 6 and C# 10 Support #419

Merged
merged 8 commits into from
Nov 9, 2021
Merged

Add .NET 6 and C# 10 Support #419

merged 8 commits into from
Nov 9, 2021

Conversation

RehanSaeed
Copy link
Owner

@RehanSaeed RehanSaeed commented Oct 19, 2021 •
edited

  • Add .NET 6 target framework.
  • Destructure many more exceptions without reflection.
  • Remove .NET Standard 1.6 target framework.
  • Remove support for Mono.
  • Add more target frameworks to EF, Refit etc. packages based on those NuGet packages.
  • Fix wrong paramName set in ArgumentNullException.
  • Use ArgumentNullException.ThrowIfNull where available.
  • Add embedded README.md to NuGet packages (https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets#packagereadmefile).

Will not merge until .NET 6 is released. Remaining work:

  • Upgrade to EF Core 6.
  • Check the target frameworks that Serilog will support in .NET 6.
  • Will update the .editorconfig in a later PR and go with file scoped namespaces.

@RehanSaeed RehanSaeed added enhancement Issues describing an enhancement or pull requests adding an enhancement. major Pull requests requiring a major version update according to semantic versioning. labels Oct 19, 2021
@RehanSaeed RehanSaeed changed the title Add .NET 6 & C# 10 Support Add .NET 6 and C# 10 Support Oct 19, 2021
FroggieFrog
FroggieFrog reviewed Oct 26, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@RehanSaeed RehanSaeed merged commit ea081fa into main Nov 9, 2021
@RehanSaeed RehanSaeed deleted the add-dotnet-6-and-csharp-10 branch November 9, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroggieFrog FroggieFrog FroggieFrog left review comments

@krajek krajek Awaiting requested review from krajek

Assignees
No one assigned
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. major Pull requests requiring a major version update according to semantic versioning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RehanSaeed @FroggieFrog