Updates ReflectionBasedDestructurer to destructure IQueryable values to prevent enumeration. #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almostchristian
changed the title
RehanSaeed
reviewed
Nov 2, 2021
Source/Serilog.Exceptions/Destructurers/ReflectionBasedDestructurer.cs
Outdated
Show resolved
Hide resolved
…ge 'IQueryable skipped'.
RehanSaeed
approved these changes
Nov 4, 2021
RehanSaeed
added
enhancement
|
After updating to v8.0.0 I'm seeing weird behaviour when logging DbUpdateExceptions. The Log method simply never returns but keeps one of my CPU cores pinned at 100%. Everything works as expected if I downgrade to v 7.1.0 and install the ef core specific package with version 5.7.0. (I'm still on EF Core 3.1) |
|
@sorenlorentzen thanks a lot for the report. Could you use a profiler to identify what is taking 100% CPU? |
|
I sure can. Would you like me to open a new issue or is it fine to just keep the discussion here? |
|
I guess new issue is cleaner, but do as you like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #100
Updates
ReflectionBasedDestructurerto destructureIQueryablevalues to prevent enumeration.