Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement gRPC destructurer #563

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Implement gRPC destructurer #563

merged 2 commits into from
Aug 15, 2022

Conversation

olsh
Copy link
Contributor

@olsh olsh commented Aug 11, 2022 •
edited
Loading

Implemented a gRPC destructurer (RpcException).
Added some tests.

@RehanSaeed
Copy link
Owner

This looks good. The only thing missing is to update the README.md file with info about this package. You can see how others are done.

@RehanSaeed RehanSaeed added enhancement Issues describing an enhancement or pull requests adding an enhancement. minor Pull requests requiring a minor version update according to semantic versioning. labels Aug 15, 2022
@olsh
Copy link
Contributor Author

olsh commented Aug 15, 2022

Hi @RehanSaeed
I've just added the info to readme. The only thing I didn't find is Azure builds.

@RehanSaeed RehanSaeed merged commit def71ab into RehanSaeed:main Aug 15, 2022
@RehanSaeed
Copy link
Owner

Thanks for the PR.

@olsh olsh deleted the grpc branch August 15, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. minor Pull requests requiring a minor version update according to semantic versioning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olsh @RehanSaeed