Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added limitedBox extension #72

Merged
merged 2 commits into from
Feb 16, 2022
Merged

added limitedBox extension #72

merged 2 commits into from
Feb 16, 2022

Conversation

chomosuke
Copy link
Contributor

First of all, thank you for making this wonderful library. It improves my code significantly.

I've removed the pubspec.lock file as per flutter guideline.

I've also made a lot of changes by auto formatting on save. I can remove them if you dislike it.

@ReinBentdal
Copy link
Owner

ReinBentdal commented Feb 6, 2022

Thanks for your contribution!
As you have probably seen a lot of the widgets in this library support implicit animations. I guess LimitedBox doesn't need that.

Could you also remove the examples/pubspec.lock file from the repository to match changes in gitignore?

@chomosuke
Copy link
Contributor Author

chomosuke commented Feb 11, 2022

Hi, changes in gitignore does not actually ignore examples/pubspec.lock file.

Furthermore, I don't think examples/pubspec.lock file should be removed. examples is a project and should probably have its pubspec committed to git.

@ReinBentdal
Copy link
Owner

either way it's not a big deal. Accepts PR

@ReinBentdal ReinBentdal merged commit 0f0452d into ReinBentdal:master Feb 16, 2022
@chomosuke chomosuke deleted the addLimited branch February 19, 2022 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants