Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/next question #5

Merged
merged 4 commits into from
Mar 10, 2019
Merged

Feat/next question #5

merged 4 commits into from
Mar 10, 2019

Conversation

Reinoptland
Copy link
Owner

@Reinoptland Reinoptland commented Mar 10, 2019 •
edited
Loading

What this pullrequest does:

  • When the the breedList has been fetched GAME_STARTED is dispatched which will set currentBreeds so the game can begin.
  • The amount of currentBreeds set at the start of the game (breedcount) can be altered in the initialstate of the questionReducer
  • Next questions can be created using the nextQuestion action
  • nextQuestion gets called when a user has clicked the correctAnswer
  • Moved the logic for sampling and and shuffling breeds to lib/utils
  • Removed SET_QUESTION_IMG_URL, fetching the image url is now part of nextQuestion action

A gif to summarise the changes:

Mar-10-2019 12-02-53

@Reinoptland Reinoptland merged commit 7ca9c0c into development Mar 10, 2019
@Reinoptland Reinoptland mentioned this pull request Mar 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Reinoptland