Make MatchFailure a subtype of Exception #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NHDaly Please let me know if this change should be reported at the end of the README.md file as yet another difference between |
|
🤷 i don't know, i don't think you need to call this out in the README unless you want to. Also, 👍 @nystrom is the real owner of this package, not me. Thanks for the review Nate :) |
NHDaly
approved these changes
Jul 5, 2022
|
Yeah, no need for the README change. Thanks @NHDaly |
|
Thank you very much both of you for your prompt reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@matchmacro can throw an object of typeMatchFailure. It'd make sense to let this type be a subtype ofExceptionso that it can be effortlessly caught intry-catchexpressions.