Asynchronous protocol support #2
Conversation
|
I did a first pass and will do more later. Not really related to this PR, but I noticed that some network calls (like Also it would be great if we get this package indexed in https://pkg.go.dev/ and have a badge that links to the docs in the readme. (See https://pkg.go.dev/about#creating-a-badge) |
|
@Segflow the PR is ready for another check |
| return &result, err | ||
| } | ||
|
|
||
| func (c *Client) GetTransactionResults(id string) ([]ArrowRelation, error) { |
There was a problem hiding this comment.
Should the user know that we use Arrow? Shouldn't that be abstracted from the user?
There was a problem hiding this comment.
That's what we are doing exactly for JS, Java and Csharp sdks, I believe there is a plan to address the query async results format so probably we won't keep this format in the future.
| return result, err | ||
| } | ||
|
|
||
| func (c *Client) GetTransactionProblems(id string) ([]interface{}, error) { |
There was a problem hiding this comment.
I believe we can't avoid returning the []interface{} here?
There was a problem hiding this comment.
I think that's the case since we expect two different types of problems ClientProblems and IntegrityConstraintViolation, I believe this is an option to achieve polymorphism in go
rai/models.go
Outdated
| DatabaseName string `json:"database_name,omitempty"` | ||
| ReadOnly bool `json:"read_only,omitempty"` | ||
| Query string `json:"query,omitempty"` | ||
| LastRequestedInterval string `json:"last_requested_interval,omitempty"` |
There was a problem hiding this comment.
Is this a timestamp or a time or what?
There was a problem hiding this comment.
from what I see it's a string "last_requested_interval":"0s", not sure about the exact meaning
This pull request adds the asynchronous protocol support to the go sdk:
ExecuteAsync,ExecuteAsyncWait,GetTransaction,GetTransactions,GetTransactionResults,GetTransactionMetadataandGetTransactionProblems.