Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a bibliography system using citation-js #59

Closed
wants to merge 7 commits into from

Conversation

Drew-S
Copy link
Member

@Drew-S Drew-S commented May 23, 2018

With the added bibliography system users only need to use +cite(key) to create an (in text) citation. Then add a +bibliography(style) to the bottom. The system uses citation-js so keys and styles need to be supported values. Style should be 'citation-apa'. Currently I have not figured out a way to use a local bibtex file library yet.

@Zulko
Copy link
Member

Zulko commented May 23, 2018

This is cool, but my main objections are (1) it adds a Javascript import in the page by default, while it should only import it when bibliography is used, and (2) it runs javascript at page rendering time, which I want to avoid if possible, the page should be as "definitive" as possible when fed to chromium. The reason is that right now there is no way to know that the javascript has totally ended before rendering the page, so for big documents the bibliography may be skipped without a warning. There may be a way to run the bibliography at pug compilation time some way.

If you solve (1) I can merge it, for (2) I'll try a bit when I have time.

@Drew-S Drew-S mentioned this pull request May 23, 2018
@Drew-S Drew-S closed this May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants