Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/pro-1299-add-a-insert_images_folder #456

Merged
merged 3 commits into from Feb 16, 2022
Merged

feature/pro-1299-add-a-insert_images_folder #456

merged 3 commits into from Feb 16, 2022

Conversation

ofrighil
Copy link
Contributor

No description provided.

@ofrighil ofrighil marked this pull request as ready for review February 15, 2022 18:45
boba-and-beer
boba-and-beer suggested changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@boba-and-beer boba-and-beer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this please? create a few sample.jpgs that are just byte files and see if they detect it. If this doesn't work - would be good to just download a few images on the internet.

boba-and-beer
boba-and-beer suggested changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@boba-and-beer boba-and-beer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main things:

  • Mock a test
  • Add examples documentation on how to use it

@ofrighil ofrighil merged commit 0c8cbb2 into development Feb 16, 2022
@ofrighil ofrighil deleted the feature/pro-1299-add-a-insert_images_folder branch February 16, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boba-and-beer boba-and-beer boba-and-beer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ofrighil @boba-and-beer