-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move ramstk_status to sub-package #1004
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1004 +/- ##
==========================================
+ Coverage 94.91% 94.92% +0.01%
==========================================
Files 180 182 +2
Lines 5312 5325 +13
Branches 506 507 +1
==========================================
+ Hits 5042 5055 +13
Misses 235 235
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.50%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Kudos, SonarCloud Quality Gate passed!
|
Does this PR introduce a breaking change?
Describe the purpose of this pull request.
To move the common database tables to sub-packages under commondb.
Describe how this was implemented.
Created status sub-package. Moved ramstk_status.py to sub-package as record.py. Created table.py. Updated ramstk_status test suite and documentation.
Describe any particular area(s) reviewers should focus on.
None
Provide any other pertinent information.
Partially implements #846
Pull Request Checklist
Code Style
Static Checks
this PR.
Tests
Chores
this PR. These problem areas have been decorated with an ISSUE: # comment.