-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: widget sensitivity not changing on subcategory change #1020
Conversation
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 1.26%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #1020 +/- ##
=======================================
Coverage 94.80% 94.80%
=======================================
Files 144 144
Lines 5194 5194
Branches 508 508
=======================================
Hits 4924 4924
Misses 233 233
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Does this PR introduce a breaking change?
Describe the purpose of this pull request.
To fix the problem with the widget sensitivity not changing when the subcategory was changed without running a calculation or deselecting and reselecting the changed component.
Describe how this was implemented.
Removed the _do_set_sensitive() listener method in the Panel metaclass. Removed the lines that loaded the widgets in the _do_set_sensitive() methods; the widgets should be blank anyway after selecting a new subcategory. Set each component type's _do_set_sensitive() method to be called whenever the subcategory is changed.
Describe any particular area(s) reviewers should focus on.
None
Provide any other pertinent information.
Closes #978
Pull Request Checklist
Code Style
Static Checks
this PR.
Tests
Chores
this PR. These problem areas have been decorated with an ISSUE: # comment.