-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: use database triggers to add records on Hardware insert #1026
Conversation
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.16%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
SonarCloud Quality Gate failed.
|
Codecov Report
@@ Coverage Diff @@
## master #1026 +/- ##
==========================================
+ Coverage 94.80% 94.85% +0.05%
==========================================
Files 144 144
Lines 5194 5247 +53
Branches 508 522 +14
==========================================
+ Hits 4924 4977 +53
Misses 233 233
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Does this PR introduce a breaking change?
Describe the purpose of this pull request.
To use triggers to add new records to associated tables (design electric, design mechanic, mil-hdk-217f, nswc, and reliability) when a new record is added to the hardware table.
Describe how this was implemented.
Added triggers to database. Added methods to associated table to insert node in it's tree. Updated test suite and stub files.
Describe any particular area(s) reviewers should focus on.
None
Provide any other pertinent information.
Closes #985
Pull Request Checklist
Code Style
Static Checks
this PR.
Tests
Chores
this PR. These problem areas have been decorated with an ISSUE: # comment.