Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor the plot widget class #1040

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Conversation

weibullguy
Copy link
Collaborator

Does this PR introduce a breaking change?

  • Yes
  • No

Describe the purpose of this pull request.

To refactor the plot widget.

Describe how this was implemented.

Made one code smell fix. This class must have been refactored some time in the past.

Describe any particular area(s) reviewers should focus on.

None

Provide any other pertinent information.

Closes #808

Pull Request Checklist

  • Code Style

    • [ X] Code is following code style guidelines.
  • Static Checks

    • Failing static checks are only applicable to code outside the scope of
      this PR.
  • Tests

    • At least one test for all newly created functions/methods?
  • Chores

    • Issue(s) have been raised for problem areas outside the scope of
      this PR. These problem areas have been decorated with an ISSUE: # comment.

@github-actions github-actions bot added the type: refactor Issue or PR dealing with refactoring of RAMSTK code. label Mar 30, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.0% 8.0% Duplication

@weibullguy weibullguy self-assigned this Mar 30, 2022
@github-actions github-actions bot added the status: inprogress Issue or PR is open, milestoned, and assigned. label Mar 30, 2022
@weibullguy weibullguy added the priority: normal Issue or PR is normal priority. label Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #1040 (0c6a94e) into master (2e8689e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1040   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files         144      144           
  Lines        5400     5400           
  Branches      574      574           
=======================================
  Hits         5141     5141           
  Misses        230      230           
  Partials       29       29           
Flag Coverage Δ
3.6 95.20% <ø> (ø)
3.7 95.20% <ø> (ø)
3.8 95.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8291393...0c6a94e. Read the comment docs.

@weibullguy weibullguy merged commit b1ad222 into master Mar 30, 2022
@trafico-bot trafico-bot bot added the endgame: merged Pull Request has been merged successfully label Mar 30, 2022
@weibullguy weibullguy deleted the refactor/issue-808 branch March 30, 2022 23:12
@weibullguy weibullguy added status: closed Pull Request is complete and integrated or closed for anther reason. and removed status: inprogress Issue or PR is open, milestoned, and assigned. labels Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
endgame: merged Pull Request has been merged successfully priority: normal Issue or PR is normal priority. status: closed Pull Request is complete and integrated or closed for anther reason. type: refactor Issue or PR dealing with refactoring of RAMSTK code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor RAMSTKPlot class
1 participant