Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ab#74335 create wysiwyg editor question #2456

Closed
wants to merge 9 commits into from

Conversation

MwanPygmay
Copy link
Contributor

@MwanPygmay MwanPygmay commented Mar 22, 2024

Description

Add editor question in surveyjs
Add support in grid: question opens in modal
Remove question from aggregations and add warning

In map popups, text and summary cards widgets, did not change anything as it was already supported.

Useful links

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added the question in several widgets.

Screenshots

image
image
image

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@MwanPygmay MwanPygmay marked this pull request as draft March 22, 2024 15:12
@MwanPygmay MwanPygmay marked this pull request as ready for review March 26, 2024 15:09
@NathanHGit NathanHGit self-requested a review March 29, 2024 08:53
@NathanHGit NathanHGit added the enhancement New feature or request label Mar 29, 2024
@NathanHGit
Copy link
Contributor

What I did: I fixed a bug of duplication in grids and disabled the editor question in dashboard filters.

The new feature seems to work fine, however, the default value isn't handled. I left a comment where it doesn't work.

@AntoineRelief AntoineRelief deleted the AB#74335_create_WYSIWYG_editor_question branch May 14, 2024 09:27
@AntoineRelief
Copy link
Collaborator

closing this one, as this new PR:
#2522
is up to date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants