Skip to content

Commit

Permalink
remove speaker icon to prioritize favorite star #519
Browse files Browse the repository at this point in the history
  • Loading branch information
Rello committed Aug 19, 2021
1 parent 9c5ad7e commit 6583055
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 16 deletions.
15 changes: 9 additions & 6 deletions CHANGELOG.md
Expand Up @@ -4,11 +4,13 @@ All notable changes to the Audio Player project will be documented in this file.
## 3.2.0 - 2021-08-xx
### Added
- NC22
- Dashboard Widget #548
- Dashboard Widget [#548](https://github.com/rello/audioplayer/issues/548)
- Collaborative tags support [#549](https://github.com/rello/audioplayer/issues/549)

### Changed
- Update Czech localization [#546](https://github.com/rello/audioplayer/pull/546) @[p-bo](https://github.com/p-bo)
- better player integration
- better player UI
- remove speaker icon to prioritize favorite star #519

### Fixed
- Previous track button when shuffle is enabled #542
Expand All @@ -17,13 +19,14 @@ All notable changes to the Audio Player project will be documented in this file.
- occ scan errors when scan folder is not available anymore #539
- Track numbers limited to 2 digits #537
- Deleted songs dont get removed #533
- Incorrect placement of tracklist in album cover view #520

## 3.1.0 - 2021-02-17
### Added
- aac support [#527](https://github.com/rello/audioplayer/pull/527)
- Remember playback volume [#517](https://github.com/rello/audioplayer/pull/517)
- NC21 [#515](https://github.com/rello/audioplayer/pull/515)
- Added .jpeg File Extension for cover art [#514](https://github.com/rello/audioplayer/pull/514) @[tidoni](https://github.com/tidoni)
- aac support [#527](https://github.com/rello/audioplayer/issues/527)
- Remember playback volume [#517](https://github.com/rello/audioplayer/issues/517)
- NC21 [#515](https://github.com/rello/audioplayer/issues/515)
- Added .jpeg File Extension for cover art [#514](https://github.com/rello/audioplayer/issues/514) @[tidoni](https://github.com/tidoni)

### Changed
- Volume slider size [#516](https://github.com/rello/audioplayer/pull/516)
Expand Down
20 changes: 10 additions & 10 deletions js/app.js
Expand Up @@ -132,8 +132,8 @@ OCA.Audioplayer.Core = {
OCA.Audioplayer.Category.handleCategoryClicked(null, function () { // select the last played title
if (OCA.Audioplayer.Core.CategorySelectors[2]) {
let item = $('#individual-playlist li[data-trackid="' + OCA.Audioplayer.Core.CategorySelectors[2] + '"]');
item.find('.icon').hide();
item.find('.ioc').removeClass('ioc-volume-up').addClass('ioc-volume-off').show();
//item.find('.icon').hide();
//item.find('.ioc').removeClass('ioc-volume-up').addClass('ioc-volume-off').show();
document.querySelector('#individual-playlist li[data-trackid="' + OCA.Audioplayer.Core.CategorySelectors[2] + '"]').scrollIntoView({behavior: 'smooth', block: 'center',});
if (OCA.Audioplayer.Core.CategorySelectors[3]) {
// if the title was previously played, the last position will be set
Expand Down Expand Up @@ -728,22 +728,22 @@ OCA.Audioplayer.UI = {
// reset all playing icons
let iocIcon = document.querySelectorAll('.albumwrapper li i.ioc');
for (let i = 0; i < iocIcon.length; ++i) {
iocIcon[i].style.display = 'none';
//iocIcon[i].style.display = 'none';
}
let iconIcon = document.querySelectorAll('.albumwrapper li i.icon');
for (let j = 0; j < iconIcon.length; ++j) {
iconIcon[j].style.display = 'block';
//iconIcon[j].style.display = 'block';
}

if (!OCA.Audioplayer.Player.isPaused()) {
iocIcon[OCA.Audioplayer.Player.currentTrackIndex].classList.remove('ioc-volume-off');
iocIcon[OCA.Audioplayer.Player.currentTrackIndex].classList.add('ioc-volume-up');
//iocIcon[OCA.Audioplayer.Player.currentTrackIndex].classList.remove('ioc-volume-off');
//iocIcon[OCA.Audioplayer.Player.currentTrackIndex].classList.add('ioc-volume-up');
} else {
iocIcon[OCA.Audioplayer.Player.currentTrackIndex].classList.add('ioc-volume-off');
iocIcon[OCA.Audioplayer.Player.currentTrackIndex].classList.remove('ioc-volume-up');
//iocIcon[OCA.Audioplayer.Player.currentTrackIndex].classList.add('ioc-volume-off');
//iocIcon[OCA.Audioplayer.Player.currentTrackIndex].classList.remove('ioc-volume-up');
}
iocIcon[OCA.Audioplayer.Player.currentTrackIndex].style.display = 'block';
iconIcon[OCA.Audioplayer.Player.currentTrackIndex].style.display = 'none';
//iocIcon[OCA.Audioplayer.Player.currentTrackIndex].style.display = 'block';
//iconIcon[OCA.Audioplayer.Player.currentTrackIndex].style.display = 'none';

document.getElementById('nowPlayingText').innerHTML = iocIcon[OCA.Audioplayer.Player.currentTrackIndex].parentElement.parentElement.dataset.title;
document.querySelectorAll('.albumwrapper li')[OCA.Audioplayer.Player.currentTrackIndex].classList.add('isActive');
Expand Down

0 comments on commit 6583055

Please sign in to comment.