Fix panic caused by the clear method of FactoryVecDeque

Signed-off-by: Aaron Erhardt <aaron.erhardt@t-online.de>
Relm4 · Dec 31, 2021 · 7933cd6 · 7933cd6
1 parent 69248dd
commit 7933cd6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -2,6 +2,12 @@
 
 ## Unreleased
 
+### Fixed
+
++ relm4: Fix panic caused by the clear method of FactoryVecDeque
+
+## 0.4.0-beta.3 - 2021-12-28
+
 ### Added
 
 + relm4: A factory view implementation for libadwaita's StackView

diff --git a/src/factory/collections/factory_vec_deque.rs b/src/factory/collections/factory_vec_deque.rs
@@ -248,12 +248,10 @@ where
 
     /// Remove all data from the [`FactoryVecDeque`].
     pub fn clear(&mut self) {
-        for index in 0..self.data.len() {
-            self.add_change(Change {
-                ty: ChangeType::Remove(1),
-                index,
-            })
-        }
+        self.add_change(Change {
+            ty: ChangeType::Remove(self.data.len() as u16),
+            index: 0,
+        });
         self.data.clear();
     }