Micro components #50
Merged
Micro components #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronErhardt
reviewed
Nov 5, 2021
AaronErhardt
reviewed
Nov 5, 2021
src/micro_component.rs
Outdated
Comment on lines
72
to
74
| pub fn update_view(&self) { | ||
| todo!() | ||
| } |
There was a problem hiding this comment.
The same as in the event loop. Try to acquire the widgets and the model and then call view. This function could theoretically return a Result instead of error handling through logs.
- Removed unneeded Option from model and widgets, - implemented `update_view`
Currently only the handler of events is interested in the `data` which makes `data` a `dead_code`. So I've commented it out
- gtk from 0.3 to 0.3.1 - libadwaita from 0.1.0-alpha-5 to 0.1.0-alpha-6
AaronErhardt
approved these changes
Nov 7, 2021
| /// Formats [`MicroComponentError`] for debug format `{:?}` | ||
| /// | ||
| /// This allows you to print errors without doing `matching` or `if let` statements | ||
| impl Debug for MicroComponentError { |
There was a problem hiding this comment.
Is there a specific reason to manually implement this? I think using #derive[Debug] should do the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #49
It's required to make #46 go forward