Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"brix11 make" does not set the exit code after build errors #155

Open
ClausKlein opened this issue Oct 12, 2023 · 2 comments
Open

"brix11 make" does not set the exit code after build errors #155

ClausKlein opened this issue Oct 12, 2023 · 2 comments

Comments

@ClausKlein
Copy link

ClausKlein commented Oct 12, 2023

Product
TAOX11

Version
Your TAOX11 version
master

Describe the bug
After an error, brix11 make should NOT continue and set an exit error code

To Reproduce
Parts of my makefile.mk

# ...
builddriver bin/brix11 make -v -v

# FIXME: install is only partly usable!
make -j ${BRIX11_NUMBER_OF_PROCESSORS} -C "${X11_BASE_ROOT}" install 2>&1 | tee make-install.log

Expected behavior
Like make, stop and set exit code != 0

Output
Any output (shell/compiler) that is given. When it is a runtime bug please set X11_LOG_MASK=all and attach the runtime output as attachment

Environment:
Output of ruby -v && bin/brix11 env && bin/brix11 -- configure --print-config

export ACE_ROOT=/axcioma/ACE/ACE
export BZIP2_ROOT=/usr
export LD_LIBRARY_PATH=/axcioma/lib:/axcioma/ACE/ACE/lib:/usr/lib:/axcioma/lib:/axcioma/ACE/ACE/lib:/usr/local/lib:/usr/lib
export MPC_BASE=/axcioma/taox11/bin/MPC
export MPC_ROOT=/axcioma/ACE/MPC
export PATH=/axcioma/bin:/axcioma/taox11/bin:/axcioma/bin:/axcioma/taox11/bin:/axcioma/ACE/ACE/bin:/root/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
export RIDL_BE_PATH=:/axcioma/taox11
export RIDL_BE_SELECT=c++11
export RIDL_ROOT=/axcioma/ridl/lib
export SSL_ROOT=/usr
export TAOX11_ROOT=/axcioma/taox11
export TAO_ROOT=/axcioma/ACE/TAO
export X11_BASE_ROOT=/axcioma
export ZLIB_ROOT=/usr
========================= config.h =========================
#define ACE_HAS_VERSIONED_NAMESPACE 1
#define ACE_MONITOR_FRAMEWORK 0
#include "ace/config-linux.h"
=================== platform_macros.GNU ====================
crossbuild=0
ssl=1
bzip2=1
zlib=1
valgrind=0
valgrind_keep_debuginfo=0
acetaompc=1
cross=0
debug=0
inline=1
optimize=1
buildbits=64
c++std=c++17
include $(ACE_ROOT)/include/makeinclude/platform_linux.GNU
===================== default.features =====================
crossbuild=0
ssl=1
bzip2=1
zlib=1
valgrind=0
valgrind_keep_debuginfo=0
acetaompc=1
cross=0
========================= MPC.cfg ==========================
includes = $MPC_ROOT/config, $ACE_ROOT/bin/MakeProjectCreator/config, $TAOX11_ROOT/bin/MPC/config
dynamic_types = $MPC_ROOT, $TAO_ROOT/MPC, $ACE_ROOT/bin/MakeProjectCreator, $TAOX11_ROOT/bin/MPC
main_functions = cplusplus:ACE_TMAIN
========================= .ridlrc ==========================
{
  "backend": "c++11",
  "be_path": [
    "taox11"
  ]
}
======================== .brix11rc =========================
{
  "project_type": "gnuace",
  "project_compiler": "gnu",
  "brix_paths": [
    "taox11"
  ],
  "user_environment": {
    "SSL_ROOT": "/usr",
    "BZIP2_ROOT": "/usr",
    "ZLIB_ROOT": "/usr",
    "ACE_ROOT": "/axcioma/ACE/ACE",
    "TAO_ROOT": "/axcioma/ACE/TAO",
    "MPC_ROOT": "/axcioma/ACE/MPC",
    "LD_LIBRARY_PATH": "/usr/lib:${LD_LIBRARY_PATH}"
  },
  "crossbuild": false,
  "target_platform": "Linux"
}
====================== workspace.mwc =======================
workspace {
  $(ACE_ROOT)/ace
  $(ACE_ROOT)/apps/gperf/src
  $(TAO_ROOT)/TAO_IDL
  $(TAO_ROOT)/tao
  $(TAO_ROOT)/orbsvcs/orbsvcs/CosNaming.mpc
  $(TAO_ROOT)/orbsvcs/orbsvcs/CosNaming_Serv.mpc
  $(TAO_ROOT)/orbsvcs/orbsvcs/CosNaming_Skel.mpc
  $(TAO_ROOT)/orbsvcs/Naming_Service
  $(TAO_ROOT)/orbsvcs/orbsvcs/Svc_Utils.mpc
  $(TAO_ROOT)/orbsvcs/tests/Simple_Naming
  $(TAO_ROOT)/utils/catior/catior.mpc
  $(TAOX11_ROOT)/tao/x11
  $(TAOX11_ROOT)/orbsvcs/orbsvcs
}
============================================================
Test config: LINUX Linux FIXED_BUGS_ONLY SSL BZIP2 ZLIB ACETAOMPC

Additional context
Add any other context about the problem here.

Generation Time: 20s
/usr/local/bin/builddriver
builddriver executing: 'bin/brix11 make -v -v'
Compilation SUCCEED in 371.004798 seconds
Number of warnings: 700
Number of errors: 113
Last Error:
  Message: "non-constexpr declaration of 'make_reference' follows constexpr declaration"
  Path: ../../../tao/x11/ifr_client/IFR_BasicC.h
  Line Number: 2155
  Column: 65
For full log, please open: /var/folders/wb/ckvxxgls5db7qyhqq4y5_l1c0000gq/T/build-0qk0nznc.log

GNUmakefile: /Users/clausklein/Workspace/cpp/axcioma/ACE/ACE/ace/GNUmakefile.ACE MAKEFLAGS= --jobserver-fds=4,5 -j

perl -ne'if (/^#END MPC-Generated Install Info/) {exit 0}' \
	  -e'elsif (/^#BEGIN MPC-Generated Install Info/) {$ok=1}' \
	  -e'elsif ($ok && s/^#//) {print}' GNUmakefile.ACE | \
	/Users/clausklein/Workspace/cpp/axcioma/ACE/MPC/prj_install.pl -i -s lib_output,header_files,template_files,inline_files,installdata_files \
	  -b header_files=include/ace -b template_files=include/ace -b inline_files=include/ace -o lib_output=lib -x installdata_files -b installdata_files=share/ace   \
	  /Users/clausklein/Workspace/cpp/axcioma/stagedir
/Users/clausklein/Workspace/cpp/axcioma/ACE/ACE/bin/ace_install_pkgconfig.pl ACE.pc.in --destdir "" --prefix /Users/clausklein/Workspace/cpp/axcioma/stagedir --libdir lib --libs "" --version 7.1.1
perl -i -pe's!\$[{(]ACE_ROOT[})]!/Users/clausklein/Workspace/cpp/axcioma/stagedir/include!g unless /^\s*include / || /^INS/' /Users/clausklein/Workspace/cpp/axcioma/stagedir/share/ace/include/makeinclude/wrapper_macros.GNU
perl -i -pe'BEGIN {$lib = qq(/Users/clausklein/Workspace/cpp/axcioma/stagedir/lib); $lp = qq(-value_project libpaths+=$lib\n); $cl = qq(command_line =)}' -e'if ($. == 1 && /^$cl (.*)/ && $1 !~ /$lib\b/) {chomp; print qq($_ $lp); $_ = qq()}' -e'elsif ($. == 1 && !/^$cl/) {print qq($cl $lp)}' /Users/clausklein/Workspace/cpp/axcioma/stagedir/share/ace/bin/MakeProjectCreator/config/MPC.cfg
perl -i -ne'print unless /^\s*ARCH\s*[+?:]?=/' /Users/clausklein/Workspace/cpp/axcioma/stagedir/share/ace/include/makeinclude/platform_macros.GNU
echo export ACE_ROOT=/Users/clausklein/Workspace/cpp/axcioma/stagedir/share/ace> /Users/clausklein/Workspace/cpp/axcioma/stagedir/share/ace/ace-devel.sh
@ClausKlein ClausKlein changed the title "brirx11 make" does not set the exit code after build errors "brix11 make" does not set the exit code after build errors Oct 12, 2023
@jwillemsen
Copy link
Member

jwillemsen commented Oct 12, 2023

We fixed #43 years ago, maybe there is another issue in that area

@ClausKlein
Copy link
Author

bash-5.2$ /usr/local/Cellar/ruby/3.2.2_1/bin/ruby bin/brix11 make
# ...

ERROR: (g++) file: ../../../tao/x11/ifr_client/IFR_BasicC.h line: 2155 - non-constexpr declaration of 'make_reference' follows constexpr declaration
      friend TAOX11_CORBA::object_reference<_Tp1> TAOX11_CORBA::make_reference(Args&& ...args);
                                                                ^
INFO: (g++) file: ../../../tao/x11/object_traits_t.h line: 242 - previous declaration is here
ERROR: (make)  - [.shobj/IFR_ExtendedS.o] Error 1
ERROR: (make)  - Waiting for unfinished jobs....
ERROR: (make)  - [.shobj/IFR_BasicS.o] Error 1
ERROR: (make)  - [.shobj/IFR_ComponentsS.o] Error 1
ERROR: (make)  - [.shobj/IFR_BaseS.o] Error 1
bash-5.2$ echo $?
0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants