Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] remove ampty authors, references #32

Merged
merged 4 commits into from
Jan 20, 2023
Merged

[ENH] remove ampty authors, references #32

merged 4 commits into from
Jan 20, 2023

Conversation

Remi-Gau
Copy link
Owner

fixes #28
fixes #29
fixes #30

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 20, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.55%.

Quality metrics Before After Change
Complexity 5.75 ⭐ 5.81 ⭐ 0.06 👎
Method Length 86.46 🙂 74.76 🙂 -11.70 👍
Working memory 8.65 🙂 8.30 🙂 -0.35 👍
Quality 63.32% 🙂 64.87% 🙂 1.55% 👍
Other metrics Before After Change
Lines 907 937 30
Changed files Quality Before Quality After Quality Change
bids2cite/authors.py 65.96% 🙂 65.08% 🙂 -0.88% 👎
bids2cite/bids2cite.py 54.41% 🙂 54.41% 🙂 0.00%
bids2cite/references.py 62.26% 🙂 62.14% 🙂 -0.12% 👎
tests/test_authors.py 96.26% ⭐ 96.17% ⭐ -0.09% 👎
tests/test_bids2cite.py 76.83% ⭐ 86.20% ⭐ 9.37% 👍
tests/test_references.py 90.40% ⭐ 94.37% ⭐ 3.97% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
bids2cite/bids2cite.py bids2cite 8 ⭐ 471 ⛔ 16 ⛔ 33.54% 😞 Try splitting into smaller methods. Extract out complex expressions
bids2cite/authors.py update_authors 13 🙂 198 😞 11 😞 44.28% 😞 Try splitting into smaller methods. Extract out complex expressions
bids2cite/references.py get_reference_info_from_pmid 15 🙂 148 😞 11 😞 47.17% 😞 Try splitting into smaller methods. Extract out complex expressions
bids2cite/bids2cite.py cli 9 🙂 234 ⛔ 9 🙂 49.42% 😞 Try splitting into smaller methods
bids2cite/authors.py parse_author 11 🙂 157 😞 8 🙂 55.85% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@ghost
Copy link

ghost commented Jan 20, 2023

Review on Crocodile

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023

Codecov Report

Merging #32 (4721cc8) into main (ec19b17) will increase coverage by 1.31%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   66.20%   67.51%   +1.31%     
==========================================
  Files           6        6              
  Lines         503      508       +5     
  Branches      102      105       +3     
==========================================
+ Hits          333      343      +10     
+ Misses        137      136       -1     
+ Partials       33       29       -4     
Flag Coverage Δ
tests 67.51% <81.81%> (+1.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bids2cite/references.py 74.07% <50.00%> (+4.62%) ⬆️
bids2cite/authors.py 71.31% <87.50%> (+1.22%) ⬆️
bids2cite/bids2cite.py 56.98% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Remi-Gau Remi-Gau merged commit 08a12b9 into main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants