see #7

Remi-Gau · 2024-05-11T17:48:42Z

No description provided.

updates: - [github.com/psf/black: 22.6.0 → 22.10.0](psf/black@22.6.0...22.10.0)

[pre-commit.ci] pre-commit autoupdate

updates: - [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](pre-commit/pre-commit-hooks@v4.3.0...v4.4.0) - [github.com/psf/black: 22.10.0 → 23.1.0](psf/black@22.10.0...23.1.0)

for more information, see https://pre-commit.ci

[pre-commit.ci] pre-commit autoupdate

for more information, see https://pre-commit.ci

improved function based on a larger redcap csv (bridge2ai)

for more information, see https://pre-commit.ci

update conversion tools and their tests

for more information, see https://pre-commit.ci

remove 3.7, add 3.11 & 3.12

pep8speaks · 2024-05-11T17:48:51Z

Hello @Remi-Gau! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file reproschema/redcap2reproschema.py:

Line 464:100: E501 line too long (151 > 99 characters)

In the file reproschema/reproschema2redcap.py:

Line 116:100: E501 line too long (109 > 99 characters)

In the file versioneer.py:

Line 1264:23: E203 whitespace before ':'

sourcery-ai

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

sourcery-ai · 2024-05-11T17:49:21Z

reproschema/reproschema2redcap.py

+    if choices and not isinstance(choices, str):
+        if isinstance(choices, list):
+            item_choices = [
+                f"{ch.get('schema:value', ch.get('value', ''))}, {ch.get('schema:name', ch.get('name', ''))}"
+                for ch in choices
+            ]
+            row_data["choices"] = " | ".join(item_choices)


suggestion (code-quality): Merge nested if conditions (merge-nested-ifs)

Suggested change

if choices and not isinstance(choices, str):

if isinstance(choices, list):

item_choices = [

f"{ch.get('schema:value', ch.get('value', ''))}, {ch.get('schema:name', ch.get('name', ''))}"

for ch in choices

]

row_data["choices"] = " | ".join(item_choices)

if choices and not isinstance(choices, str) and isinstance(choices, list):

item_choices = [

f"{ch.get('schema:value', ch.get('value', ''))}, {ch.get('schema:name', ch.get('name', ''))}"

for ch in choices

]

row_data["choices"] = " | ".join(item_choices)

Explanation
Too much nesting can make code difficult to understand, and this is especially
true in Python, where there are no brackets to help out with the delineation of
different nesting levels.

Reading deeply nested code is confusing, since you have to keep track of which
conditions relate to which levels. We therefore strive to reduce nesting where
possible, and the situation where two if conditions can be combined using
and is an easy win.

sourcery-ai · 2024-05-11T17:49:21Z

versioneer.py

+                if line.strip().startswith(versionfile_source):
+                    if "export-subst" in line.strip().split()[1:]:
+                        present = True
+                        break


suggestion (code-quality): Merge nested if conditions (merge-nested-ifs)

Suggested change

if line.strip().startswith(versionfile_source):

if "export-subst" in line.strip().split()[1:]:

present = True

break

if line.strip().startswith(versionfile_source) and "export-subst" in line.strip().split()[1:]:

present = True

break

Explanation
Too much nesting can make code difficult to understand, and this is especially
true in Python, where there are no brackets to help out with the delineation of
different nesting levels.

Reading deeply nested code is confusing, since you have to keep track of which
conditions relate to which levels. We therefore strive to reduce nesting where
possible, and the situation where two if conditions can be combined using
and is an easy win.

sourcery-ai · 2024-05-11T17:49:21Z

reproschema/_version.py

+                    mo = re.search(r'=\s*"(.*)"', line)
+                    if mo:
+                        keywords["refnames"] = mo.group(1)
+                if line.strip().startswith("git_full ="):
+                    mo = re.search(r'=\s*"(.*)"', line)
+                    if mo:
+                        keywords["full"] = mo.group(1)
+                if line.strip().startswith("git_date ="):
+                    mo = re.search(r'=\s*"(.*)"', line)


issue (code-quality): We've found these issues:

Use named expression to simplify assignment and conditional [×3] (use-named-expression)

Replace m.group(x) with m[x] for re.Match objects (use-getitem-for-re-match-groups)

sourcery-ai · 2024-05-11T17:49:22Z

reproschema/_version.py

@@ -230,7 +268,9 @@


 @register_vcs_handler("git", "pieces_from_vcs")
-def git_pieces_from_vcs(tag_prefix, root, verbose, run_command=run_command):
+def git_pieces_from_vcs(


issue (code-quality): We've found these issues:

Move setting of default value for variable into else branch (introduce-default-else)

Replace interpolated string formatting with f-string [×4] (replace-interpolation-with-fstring)

Merge dictionary assignment with declaration [×3] (merge-dict-assign)

Inline variable that is only used once (inline-variable)

Replace if statement with if expression (assign-if-exp)

Replace m.group(x) with m[x] for re.Match objects [×3] (use-getitem-for-re-match-groups)

Low code quality found in git_pieces_from_vcs - 20% (low-code-quality)

Explanation

The quality score for this function is below the quality threshold of 25%.
This score is a combination of the method length, cognitive complexity and working memory.

How can you solve this?

It might be worth refactoring this function to make it shorter and more readable.

Reduce the function length by extracting pieces of functionality out into
their own functions. This is the most important thing you can do - ideally a
function should be less than 10 lines.

Reduce nesting, perhaps by introducing guard clauses to return early.

Ensure that variables are tightly scoped, so that code using related concepts
sits together within the function rather than being scattered.

sourcery-ai · 2024-05-11T17:49:22Z

reproschema/_version.py

+            if pieces["dirty"]:
+                rendered += ".dirty"
+    else:
+        # exception #1
+        rendered = "0"
+        if pieces["branch"] != "master":
+            rendered += ".dev0"
+        rendered += "+untagged.%d.g%s" % (pieces["distance"], pieces["short"])
+        if pieces["dirty"]:
+            rendered += ".dirty"


issue (code-quality): We've found these issues:

Hoist conditional out of nested conditional (hoist-if-from-if)

Hoist repeated code outside conditional statement (hoist-statement-from-if)

sourcery-ai · 2024-05-11T17:49:23Z

versioneer.py

@@ -1231,12 +1538,12 @@
 """


-def versions_from_file(filename):
+def versions_from_file(filename: str) -> Dict[str, Any]:
    """Try to determine the version from _version.py if present."""
    try:


issue (code-quality): We've found these issues:

Simplify basic file reads with pathlib (path-read)

Explicitly raise from a previous error (raise-from-previous-error)

Replace m.group(x) with m[x] for re.Match objects (use-getitem-for-re-match-groups)

sourcery-ai · 2024-05-11T17:49:23Z

versioneer.py

+            if pieces["dirty"]:
+                rendered += ".dirty"
+    else:
+        # exception #1
+        rendered = "0"
+        if pieces["branch"] != "master":
+            rendered += ".dev0"
+        rendered += "+untagged.%d.g%s" % (pieces["distance"], pieces["short"])
+        if pieces["dirty"]:
+            rendered += ".dirty"


issue (code-quality): We've found these issues:

Hoist conditional out of nested conditional (hoist-if-from-if)

Hoist repeated code outside conditional statement (hoist-statement-from-if)

sourcery-ai · 2024-05-11T17:49:23Z

versioneer.py

+    """
+    if pieces["closest-tag"]:
+        rendered = pieces["closest-tag"]
+        if pieces["distance"] or pieces["dirty"]:


issue (code-quality): We've found these issues:

Split conditional into multiple branches [×2] (split-or-ifs)

Merge duplicate blocks in conditional [×2] (merge-duplicate-blocks)

Replace interpolated string formatting with f-string [×2] (replace-interpolation-with-fstring)

Hoist conditional out of nested conditional (hoist-if-from-if)

Hoist repeated code outside conditional statement (hoist-statement-from-if)

Remove redundant conditional [×2] (remove-redundant-if)

sourcery-ai · 2024-05-11T17:49:23Z

versioneer.py

@@ -1412,10 +1794,14 @@



issue (code-quality): We've found these issues:

Simplify conditional into switch-like form [×2] (switch)

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

sourcery-ai · 2024-05-11T17:49:23Z

versioneer.py

@@ -1438,7 +1824,7 @@
    """The project root directory is unknown or missing key files."""


-def get_versions(verbose=False):
+def get_versions(verbose: bool = False) -> Dict[str, Any]:
    """Get the project version from whatever source is available.


issue (code-quality): We've found these issues:

Use named expression to simplify assignment and conditional (use-named-expression)

Replace interpolated string formatting with f-string [×5] (replace-interpolation-with-fstring)

pre-commit-ci bot and others added 30 commits October 10, 2022 16:22

[pre-commit.ci] pre-commit autoupdate

b19a86b

updates: - [github.com/psf/black: 22.6.0 → 22.10.0](psf/black@22.6.0...22.10.0)

Merge pull request ReproNim#27 from ReproNim/pre-commit-ci-update-config

9cfcef4

[pre-commit.ci] pre-commit autoupdate

[pre-commit.ci] pre-commit autoupdate

4fcc568

updates: - [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](pre-commit/pre-commit-hooks@v4.3.0...v4.4.0) - [github.com/psf/black: 22.10.0 → 23.1.0](psf/black@22.10.0...23.1.0)

[pre-commit.ci] auto fixes from pre-commit.com hooks

059f4b4

for more information, see https://pre-commit.ci

Merge pull request ReproNim#28 from ReproNim/pre-commit-ci-update-config

31094ed

[pre-commit.ci] pre-commit autoupdate

convert js to python

ef27982

add redcap2rs yaml template

142089e

update yaml template

abd9c48

update instruction to use redcap2reproschema.py

675a4b2

add additional python package

1f8746d

convert redcap2rs too from js to python

550db35

[pre-commit.ci] auto fixes from pre-commit.com hooks

7881305

for more information, see https://pre-commit.ci

convert rs2redcap.js to python

f3d8992

update cli.py with reproschema2redcap

7fd5716

update readme for instruction

0c5d514

update readme for instruction

3aae7fa

[pre-commit.ci] auto fixes from pre-commit.com hooks

5485e3d

for more information, see https://pre-commit.ci

integrate redcap2rs in cli.py

a3606fb

rewrite main() for cli use

73da571

[pre-commit.ci] auto fixes from pre-commit.com hooks

4906d76

for more information, see https://pre-commit.ci

update the template

25932f8

major updates for converting

451af3c

[pre-commit.ci] auto fixes from pre-commit.com hooks

5582c74

for more information, see https://pre-commit.ci

add pyyaml to ga

4b93d47

Merge branch 'master' into redcap2reproschema

8739b10

add pyyaml to setup.cfg

4d86229

merge from master

14976ec

Update to ubuntu-latest

d5e4b8b

Merge branch 'master' into redcap2reproschema

47fb76b

Merge branch 'master' into reproschema2redcap

91b7774

pre-commit-ci bot and others added 27 commits January 19, 2024 16:55

[pre-commit.ci] auto fixes from pre-commit.com hooks

891d580

for more information, see https://pre-commit.ci

Merge pull request ReproNim#33 from yibeichan/master

9d3e929

improved function based on a larger redcap csv (bridge2ai)

add print for testing

87f7a6a

update clear_header

3162782

remove print

64521d9

fix order and other errors

4c1081a

change ui yesno to radio

50fe4ce

fix typo

4359791

update context, field->item, fix isVis

b17b5c7

remove useless due to failed validation

ca3162d

remove visibility at the item level & remove matrixInfo

4288f8a

fix choice

57ca52e

remove identifier

82e2300

fix conversion tests

3c7049f

remove test output

a60612f

change test output directory

e1e847d

final improvments on tests

51d30b7

[pre-commit.ci] auto fixes from pre-commit.com hooks

ab7c051

for more information, see https://pre-commit.ci

Merge pull request ReproNim#37 from yibeichan/master

105489b

update conversion tools and their tests

remove 3.7, add 3.11

78b8167

add py3.12

9af9054

remove 3.12

7379fcd

Update Versioneer to latest version

b4a8200

Update Versioneer to latest version

b3bcb78

update action & python version

6943e89

[pre-commit.ci] auto fixes from pre-commit.com hooks

7f378ec

for more information, see https://pre-commit.ci

Merge pull request ReproNim#38 from ReproNim/enh/py-version

b227e12

remove 3.7, add 3.11 & 3.12

sourcery-ai bot reviewed May 11, 2024

View reviewed changes

Remi-Gau closed this May 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

see #7

see #7

Remi-Gau commented May 11, 2024

pep8speaks commented May 11, 2024

sourcery-ai bot left a comment

sourcery-ai bot May 11, 2024

sourcery-ai bot May 11, 2024

sourcery-ai bot May 11, 2024

sourcery-ai bot May 11, 2024

sourcery-ai bot May 11, 2024

sourcery-ai bot May 11, 2024

sourcery-ai bot May 11, 2024

sourcery-ai bot May 11, 2024

sourcery-ai bot May 11, 2024

sourcery-ai bot May 11, 2024

see #7

see #7

Conversation

Remi-Gau commented May 11, 2024

pep8speaks commented May 11, 2024

sourcery-ai bot left a comment

Choose a reason for hiding this comment

sourcery-ai bot May 11, 2024

Choose a reason for hiding this comment

sourcery-ai bot May 11, 2024

Choose a reason for hiding this comment

sourcery-ai bot May 11, 2024

Choose a reason for hiding this comment

sourcery-ai bot May 11, 2024

Choose a reason for hiding this comment

sourcery-ai bot May 11, 2024

Choose a reason for hiding this comment

sourcery-ai bot May 11, 2024

Choose a reason for hiding this comment

sourcery-ai bot May 11, 2024

Choose a reason for hiding this comment

sourcery-ai bot May 11, 2024

Choose a reason for hiding this comment

sourcery-ai bot May 11, 2024

Choose a reason for hiding this comment

sourcery-ai bot May 11, 2024

Choose a reason for hiding this comment