Thrustlimiter with BurnCommand - resolves #42 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thrustlimiter can now changed and the burn/maneuver time calculation are now right
Closed
Peppie84
referenced
this pull request
in Peppie84/RemoteTech
Jun 1, 2014
Jaidans fix with the right thrustlimitter calculation (#62)
Merged
|
@Starstrider42 Partially correct - it solves #22 - just checking #42 |
|
@Starstrider42 As I suspected it does not solve #42 (I misread the some of the commit message, I assumed it related to #22) - burns will observe thrust limiter settings, but they will not observe the throttle slider (ie, burns are always executed at 100% throttle, regardless of slider setting) |
|
Right its not #42 😄 |
|
Merged as part of #78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thrustlimiter can now changed and the burn/maneuver time calculation are
now right