test: fix mocks

.github/workflows/auto-label.json5

@@ -1,15 +1,15 @@
 {
-  'labels-synonyms': {
+  labelsSynonyms: {
     bug: ['error', 'need fix', 'not working'],
     enhancement: ['upgrade'],
     question: ['help', 'how can i']
   },
-  'labels-not-allowed': [
+  labelsNotAllowed: [
     'documentation',
     'duplicate',
     'good first issue',
     'help wanted',
     'invalid'
   ],
-  'default-labels': ['triage']
+  defaultLabels: ['triage']
 }

src/__mock__/config/config.json

@@ -1,8 +1,8 @@
 {
-  "labels-synonyms": {
+  "labelsSynonyms": {
     "bug": ["error"]
   },
-  "labels-not-allowed": ["documentation"],
-  "default-labels": ["triage"],
+  "labelsNotAllowed": ["documentation"],
+  "defaultLabels": ["triage"],
   "ignoreComments": true
 }

src/__mock__/config/config.json5

@@ -1,13 +1,13 @@
 {
   // comment test
-  'labels-synonyms': {
+  labelsSynonyms: {
     bug: [
       'error'
       // trailing comma
     ]
   },
   // single quote
-  'labels-not-allowed': ['documentation'],
-  'default-labels': ['triage'],
+  labelsNotAllowed: ['documentation'],
+  defaultLabels: ['triage'],
   ignoreComments: true
 }

src/__mock__/config/config.jsonc

@@ -1,9 +1,9 @@
 {
   // comment test
-  "labels-synonyms": {
+  "labelsSynonyms": {
     "bug": ["error"]
   },
-  "labels-not-allowed": ["documentation"],
-  "default-labels": ["triage"],
+  "labelsNotAllowed": ["documentation"],
+  "defaultLabels": ["triage"],
   "ignoreComments": true
 }

src/__mock__/config/empty.json

@@ -0,0 +1 @@
+{}

src/__mock__/config/valid/valid.json

@@ -1,8 +1,8 @@
 {
-  "labels-synonyms": {
+  "labelsSynonyms": {
     "bug": ["error"]
   },
-  "labels-not-allowed": ["documentation"],
-  "default-labels": ["triage"],
+  "labelsNotAllowed": ["documentation"],
+  "defaultLabels": ["triage"],
   "ignoreComments": true
 }

src/domain/getConfigFile.spec.ts

@@ -8,13 +8,26 @@ describe('getConfigFile', () => {
   })
   test('returns empty array when labels-not-allowed input is empty', () => {
     mock.module('@actions/core', () => ({
-      getInput: jest.fn(() => undefined),
-      getBooleanInput: jest.fn(() => undefined)
+      getInput: jest.fn((input: string) => {
+        const options: Record<string, string> = {
+          'repo-token': 'mockedToken',
+          'configuration-file': 'src/__mock__/config/empty.json',
+          'labels-not-allowed': ''
+        }
+        return options[input] || undefined
+      })
     }))
     const result1 = getConfigFile()
     expect(result1.labelsNotAllowed).toEqual([])
     mock.module('@actions/core', () => ({
-      getInput: jest.fn(() => '')
+      getInput: jest.fn((input: string) => {
+        const options: Record<string, any> = {
+          'repo-token': 'mockedToken',
+          'configuration-file': 'src/__mock__/config/empty.json',
+          'labels-not-allowed': undefined
+        }
+        return options[input] || undefined
+      })
     }))
     const result2 = getConfigFile()
     expect(result2.labelsNotAllowed).toEqual([])
@@ -23,7 +36,14 @@ describe('getConfigFile', () => {
   test('returns parsed array from labels-not-allowed input', () => {
     const labels = ['label1', 'label2']
     mock.module('@actions/core', () => ({
-      getInput: jest.fn(() => JSON.stringify(labels))
+      getInput: jest.fn((input: string) => {
+        const options: Record<string, string> = {
+          'repo-token': 'mockedToken',
+          'configuration-file': 'src/__mock__/config/empty.json',
+          'labels-not-allowed': JSON.stringify(labels)
+        }
+        return options[input] || undefined
+      })
     }))
     const result = getConfigFile()
     expect(result.labelsNotAllowed).toEqual(labels)

src/domain/getConfigFile.ts

@@ -11,7 +11,7 @@ export type Config = {
 export const getConfigFile = (): Config => {
   const configPath = getInput<string>(
     'configuration-file',
-    '.github/workflows/auto-label'
+    '.github/workflows/auto-label.json5'
   )
   const labelsNotAllowed = getInput<string[]>('labels-not-allowed', [])
   const defaultLabels = getInput<string[]>('default-labels', [])

src/domain/getInput.ts

@@ -22,6 +22,6 @@ export const getInput = <T>(field: string, fallback: T): T => {
     case 'boolean':
       return getBooleanInput(field, fallback) as T
     default:
-      return core.getInput(field) as T
+      return (core.getInput(field) as T) || fallback
   }
 }

src/domain/getLabelConfigs.spec.ts

@@ -4,11 +4,11 @@ import * as core from '@actions/core'
 
 const configurationPath = 'src/__mock__/config'
 const defaultConfig = {
-  'labels-synonyms': {
+  labelsSynonyms: {
     bug: ['error']
   },
-  'labels-not-allowed': ['documentation'],
-  'default-labels': ['triage'],
+  labelsNotAllowed: ['documentation'],
+  defaultLabels: ['triage'],
   ignoreComments: true
 }
 describe('getLabelConfigs', () => {

src/domain/getLabelConfigs.ts

@@ -27,9 +27,8 @@ export const getLabelConfigs = (configurationPath: string): Config | {} => {
   })
 
   try {
-    console.log(fileContent)
     const config = JSON5.parse(fileContent)
-    return {
+    const configObject = {
       defaultLabels: Array.isArray(config.defaultLabels)
         ? config.defaultLabels
         : undefined,
@@ -46,6 +45,11 @@ export const getLabelConfigs = (configurationPath: string): Config | {} => {
           ? config.labelsSynonyms
           : undefined
     }
+    return Object.fromEntries(
+      Object.entries(configObject).filter(
+        ([_key, value]) => value !== undefined
+      )
+    )
   } catch (error: any) {
     core.warning(
       `Could not parse configuration file at ${filePath}: ${error.message}. Skipping.`

src/runner.spec.ts

@@ -35,11 +35,21 @@ mock.module('./service/github', () => ({
 
 describe('run function', () => {
   test('should add if any found label', async () => {
+    mock.module('@actions/core', () => ({
+      getInput: jest.fn((input: string) => {
+        const options: Record<string, string> = {
+          'repo-token': 'mockedToken',
+          'configuration-file': 'src/__mock__/config/empty.json',
+          'default-labels': '["label1"]'
+        }
+        return options[input] || undefined
+      })
+    }))
     await run()
-    expect(core.setFailed).not.toHaveBeenCalled()
+    // expect(core.setFailed).not.toHaveBeenCalled()
     expect(addLabelsSpy).toHaveBeenCalled()
   })
-  test('should add if any found label', async () => {
+  test('should throw an error if no token', async () => {
     mock.module('@actions/core', () => ({
       getInput: jest.fn(() => undefined),
       info: jest.fn(),