fixed path substring parameters in webserver.cpp #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The substring to get the path of the HTTP request was set to 3 for GET requests. However for request types with different length the length of the request type string should be used ("POST", "DELETE"...)
|
I support this change. Had a similar issue with the POST request. |
|
Ping @ReneNyffenegger would like to merge this? Otherwise I'd close this PR in order to clean up my Notification/work list |
|
@Carnageous sorry for not replying to your pull request. I am currently busy but I will take a look at it tonight, after work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The substring to get the path of the HTTP request was set to 3 for GET/PUT requests etc. However for request types with different amount of characters, the length of the request type string should be used ("POST", "DELETE"...).
Because of this when using a request type which string length != 3 the request path was not parsed correctly.