Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow image in CV header (via URL) #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

catabozan
Copy link

I have added a new property called image that can be set via the MarkDown attributes.

You can set the image to any URL and it will be displayed on the left side of the header text.

If no image is present or if it's not a valid url, it will not be displayed and the layout stays the same as the current one.

@Renovamen Renovamen mentioned this pull request May 3, 2024
@Renovamen
Copy link
Owner

Hi @catabozan, thank you for your pull request!

Adding an image is a great feature. However, before we move forward, I think we need to consider how to adjust the resume header styles when adding an image. Right now, the styles don't center the header or align it to a side, which could be improved. I don't have a clear idea yet on how to style headers with images, so I'll need some time to think about it and possibly refine this pull request before approving it.

Do you have any thoughts on this? Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants