expand data argument to remove need of array

Renovamen · Mar 26, 2021 · c32a79b · c32a79b
1 parent ac7d4b4
commit c32a79b
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 15 deletions.
diff --git a/.gitignore b/.gitignore
@@ -2,14 +2,17 @@ iconpacks/gameicons/
 *.zip
 .yarnrc
 .npmrc
-
 docs/dist/
 package/*/dist/
 package/*/dist-css/
 package/dist/*/*.js
 package/dist-css/*/*.js
 package/dist-css/*/*.css
 
+
+# vscode settings
+.vscode
+
 # Logs
 logs
 *.log

diff --git a/README.md b/README.md
@@ -80,7 +80,7 @@ import App from "./App.vue";
 import OhVueIcon from "oh-vue-icons";
 
 import { FaFlag, RiZhihuFill } from "oh-vue-icons/icons";
-OhVueIcon.add([FaFlag, RiZhihuFill]);
+OhVueIcon.add(FaFlag, RiZhihuFill);
 
 Vue.component("v-icon", OhVueIcon);
 
@@ -109,7 +109,7 @@ import App from "./App.vue";
 import OhVueIcon from "oh-vue-icons/dist/v3/icon.umd.min";
 
 import { FaFlag, RiZhihuFill } from "oh-vue-icons/icons";
-OhVueIcon.add([FaFlag, RiZhihuFill]);
+OhVueIcon.add(FaFlag, RiZhihuFill);
 
 const app = createApp(App);
 app.component("v-icon", OhVueIcon);

diff --git a/package/icon-v2/src/components/Icon.js b/package/icon-v2/src/components/Icon.js
@@ -269,10 +269,8 @@ export default {
     if (!icons[name].minY) icons[name].minY = 0;
   },
 
-  add(data) {
-    if (Array.isArray(data)) {
-      for (let icon of data) this.register(icon);
-    } else this.register(data);
+  add(...data) {
+    for (const icon of data) this.register(icon);
   },
 
   icons

diff --git a/package/icon-v2/src/main.js b/package/icon-v2/src/main.js
@@ -22,7 +22,7 @@ import {
   RiSailboatLine
 } from "../../icons";
 
-OhVueIcon.add([
+OhVueIcon.add(
   FaFlag,
   FcLinux,
   BiBattery,
@@ -40,7 +40,7 @@ OhVueIcon.add([
   BiLightning,
   HiAcademicCap,
   RiSailboatLine
-]);
+);
 
 OhVueIcon.add({
   name: "baidu",

diff --git a/package/icon-v3/src/components/Icon.js b/package/icon-v3/src/components/Icon.js
@@ -270,10 +270,8 @@ export default {
     if (!icons[name].minY) icons[name].minY = 0;
   },
 
-  add(data) {
-    if (Array.isArray(data)) {
-      for (let icon of data) this.register(icon);
-    } else this.register(data);
+  add(...data) {
+    for (const icon of data) this.register(icon)
   },
 
   icons

diff --git a/package/icon-v3/src/main.js b/package/icon-v3/src/main.js
@@ -22,7 +22,7 @@ import {
   RiSailboatLine
 } from "../../icons";
 
-OhVueIcon.add([
+OhVueIcon.add(
   FaFlag,
   FcLinux,
   BiBattery,
@@ -40,7 +40,7 @@ OhVueIcon.add([
   BiLightning,
   HiAcademicCap,
   RiSailboatLine
-]);
+);
 
 OhVueIcon.add({
   name: "baidu",