-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom and per context authentication #1
Comments
I am not sure how to test both basic and token auth in the future but i am quite sure we need to.
I guess this decision influences how to best configure the default auth in testbeat. Yolean would need this dual testing quite urgently? |
Yes, I think that makes sense. Override is likely to be authtype specific anyway. Hmm, can tests be conditionally executed? Need to break out into cookbooks? cms-auth-basic vs cms-auth-token I suggest the following context args:
|
Design idea:
Noderunner looks in the node folder for a testbeat-auth.rb file. If such a file exists it sets the NODE_AUTH env. |
Sounds like a good design. Do we have any way of including / excluding tests based on the type of Do you think we need "on40x" events? I think those things can be tested explicitly with "unauthenticated". All methods we anticipate can be handled with "before" unless we really want to test the redirect etc. I like the route forward but we might only need to implement "before" now. |
I think we want to do basic auth only on 401, at least with the embedded I guess we could add an interface method that can exclude given a context On Sun, Nov 29, 2015, 17:02 Thomas Åkesson notifications@github.com wrote:
|
One option would be to override the default user with a context arg like those used for
body
andheaders
.To override for multiple specs we could add another context detection rule.
Should we continue to assume BASIC auth, or somehow try to make authentication method pluggable?
The text was updated successfully, but these errors were encountered: