Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Object resource" template fails to put braces around path parameter in path #469

Open
andylowry opened this issue Aug 28, 2018 · 0 comments

Comments

@andylowry
Copy link
Contributor

You end up with a path string of e.g. pets/petId instead of /pets/{petId}, and this causes the overall template to contain error markers where petId parameters are declared for operations.

andylowry added a commit that referenced this issue Aug 28, 2018
This realates to issue ZEN-4367 RepreZen JIRA

The `Object resource` template does not work well with reference string
content-assist when filling in its `itemSchema` placeholder. The first
instance of the placeholder is fine, but the next one has an extra quote
in front of the ref string. This appears to be a problem with the
content-assist implementation, not something that can be addressed by
changing the template. So this commit does not fix the reported problem.

However, while investigating this issue, another bug in that template
came to light, namely that the path parameter specified via the "id"
plaaceholder in the template ends up without needed braces in the path
string. This causes corresponding parameter definitions in contained
operations to be in error.

This commit fixes the path string issue, but as to the reference string
issue, it only makes quoting of ref strings consistent throughout the
templates. Where ref strings are quoted, they are now always quoted with
double quotes, whereas before there appeared to be a somewhat random use
of double or single quotes.
tfesenko added a commit that referenced this issue Aug 28, 2018
[#469] Fix Object resource template
andylowry added a commit that referenced this issue Aug 28, 2018
Where the same reference appears more than once in a single template,
the placeholders are no longer quoted. This is due to observed buggy
behavior by eclipse in filling templates.
tfesenko added a commit that referenced this issue Aug 28, 2018
[#469] Remove quotes from some ref placeholders (WIP)
tfesenko added a commit that referenced this issue Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant