Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve Codacy Code Quality Issues #34

Open
este6an13 opened this issue Mar 17, 2024 · 0 comments
Open

Solve Codacy Code Quality Issues #34

este6an13 opened this issue Mar 17, 2024 · 0 comments
Labels
quality Code Quality Issues

Comments

@este6an13
Copy link
Contributor

este6an13 commented Mar 17, 2024

Goal

Keep code quality as high as possible.

Steps

  1. Go to Codacy.
  2. Identify an issue that you can solve.
  3. Implement the fix locally
  4. Push your changes
  5. Create your PR
@este6an13 este6an13 added the quality Code Quality Issues label Mar 17, 2024
este6an13 added a commit that referenced this issue Mar 20, 2024
- add `.markdownlint`.json` file
- remove unused `os` import
este6an13 added a commit that referenced this issue Mar 20, 2024
- add `.markdownlint`.json` file
- remove unused `os` import
este6an13 added a commit that referenced this issue Mar 20, 2024
- wrap text in `README.md` to `80`
- wrap text in `CONTRIBUTING.md` to `80`
este6an13 added a commit that referenced this issue Mar 20, 2024
- wrap text in `README.md` to `80`
- wrap text in `CONTRIBUTING.md` to `80`
este6an13 added a commit that referenced this issue Mar 20, 2024
- fix some issues in markdown format
- add codacy badge to `README.md`
este6an13 added a commit that referenced this issue Mar 20, 2024
- fix some issues in markdown format
- add codacy badge to `README.md`
este6an13 added a commit that referenced this issue Mar 22, 2024
- add funcs signatures to `vector_store` module
- remove unused imports from `llm_client` unit tests #34
este6an13 added a commit that referenced this issue Mar 22, 2024
- add funcs signatures to `vector_store` module
- remove unused imports from `llm_client` unit tests #34
este6an13 added a commit that referenced this issue Mar 23, 2024
- use md5 hash as id for each file instead of uuid
- note: this way we would prevent the system from generating
  the same file twice.
- convert map to list to actually executing write file func
- add `b` to `markdownlint.json` #34
este6an13 added a commit that referenced this issue Mar 23, 2024
- use md5 hash as id for each file instead of uuid
- note: this way we would prevent the system from generating
  the same file twice.
- convert map to list to actually executing write file func
- add `b` to `markdownlint.json` #34
este6an13 added a commit that referenced this issue Mar 23, 2024
- use md5 hash as id for each file instead of uuid
- note: this way we would prevent the system from generating
  the same file twice.
- convert map to list to actually executing write file func
- add `b` to `markdownlint.json` #34
este6an13 added a commit that referenced this issue Mar 24, 2024
- add `test_faculty_secretary_faq` unit test
- add `timeout` param to get request #34
- set folder to store generated files
este6an13 added a commit that referenced this issue Mar 24, 2024
- add `test_faculty_secretary_faq` unit test
- add `timeout` param to get request #34
- set folder to store generated files
este6an13 added a commit that referenced this issue Mar 24, 2024
- add `test_faculty_secretary_faq` unit test
- add `timeout` param to get request #34
- set folder to store generated files
este6an13 added a commit that referenced this issue Mar 24, 2024
- add `cryptography` dependency
- use `SHA256` instead of `MD5` to identify the documents
este6an13 added a commit that referenced this issue Mar 24, 2024
- add `cryptography` dependency
- use `SHA256` instead of `MD5` to identify the documents
este6an13 added a commit that referenced this issue Mar 27, 2024
- fix numeration issue in markdown files
- ignore `MD013` in `.markdownlint.json`
este6an13 added a commit that referenced this issue Mar 27, 2024
- fix numeration issue in markdown files
- ignore `MD013` in `.markdownlint.json`
este6an13 added a commit that referenced this issue Mar 30, 2024
- remove unused imports from llm client
este6an13 added a commit that referenced this issue Mar 30, 2024
- remove unused imports from llm client
este6an13 added a commit that referenced this issue Apr 13, 2024
- remove string concatenation in sql query
- rename `ìd` parameter
este6an13 added a commit that referenced this issue Apr 13, 2024
- remove string concatenation in sql query
- rename `ìd` parameter
@este6an13 este6an13 reopened this Apr 13, 2024
este6an13 added a commit that referenced this issue Apr 13, 2024
- rename duplicate `document_delete` function to `document_put`
- remove `return` statement from `document_put` function
@este6an13 este6an13 reopened this Apr 13, 2024
este6an13 added a commit that referenced this issue Apr 24, 2024
- add a title to the streamlit app tab
- remove unused imported module #34
este6an13 added a commit that referenced this issue Apr 24, 2024
- add a title to the streamlit app tab
- remove unused imported module #34
este6an13 added a commit that referenced this issue Apr 24, 2024
- add `formatPython` function from `makes`
- call function to format Python code
este6an13 added a commit that referenced this issue Apr 24, 2024
- add `formatPython` function from `makes`
- call function to format Python code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Code Quality Issues
Projects
None yet
Development

No branches or pull requests

1 participant