Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail management screen exposes password #1053

Closed
TheMightyZeus opened this issue Sep 20, 2019 · 1 comment
Closed

Mail management screen exposes password #1053

TheMightyZeus opened this issue Sep 20, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@TheMightyZeus
Copy link

The password for the email account set up in the wiki is sent to the user in the password field. This can be viewed by changing the password field type to text in developer tools, using javascript, by inspecting the response data, or by inspecting network traffic if https isn't used. There's no reason to send that data to the user, it should only be transmitted if the user is updating it.

Steps to reproduce the behavior:
Have an email address configured. In the mail section of administration, inspect the password field using your browser's developer tools and modify the type parameter to text, remove it, or enter an unsupported value. You will see the password associated with the email account.

Expected behavior
No password should ever be sent to the user. One possibility is to have a placeholder value filled into the field. This will signal to the user that a value is stored, without revealing the actual password.

Host Info

  • OS: Ubuntu Linux (bionic) 18.04 x64
  • Wiki.js version: 2.0.0-beta.303
  • Database engine: PostgreSQL 10.10
@NGPixel NGPixel added the bug Something isn't working label Sep 21, 2019
@NGPixel
Copy link
Member

NGPixel commented Sep 21, 2019

Fixed by 53cdb11

@NGPixel NGPixel closed this as completed Sep 21, 2019
jionggyu pushed a commit to jionggyu/wiki-2.5.302-patch that referenced this issue Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants