Adds IDENTITY_INSERT in rebuild-tree.js #1125 #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue when tree is being rebuilt with mssql backend
NGPixel
approved these changes
Oct 25, 2019
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
…equarks#1130) Fixes issue when tree is being rebuilt with mssql backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue when tree is being rebuilt with mssql backend.
I added a condition to only execute the wrapping with the IDENTITY_INSERT on an mssql type database. I already tested this fix in my docker container by modifying the files according to this pull request. The
rebuild indexis working as I expected it to work.At the moment I do not have the time to verify other database backends, but if this is mandatory for merging this PR please let me known and I will try to validate during the next days.
Is there anything else I can do to help getting this PR into the main repo?