Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop a PoC "SingleRequestProxy" payment smart contract that emits the paymentReference event in the receive() function #1283

Open
5 tasks
Tracked by #1159
MantisClone opened this issue Dec 6, 2023 · 3 comments

Comments

@benjlevesque
Copy link
Member

another interesting use case for this : exchanges! They don't support smart contract calls, so cannot interract with the existing proxies.

It seems important that, once used, the "one time proxy" rejects any incoming transfer

@MantisClone
Copy link
Member Author

MantisClone commented Dec 7, 2023

It seems important that, once used, the "one time proxy" rejects any incoming transfer

@benjlevesque I'm not so sure. I think we'd still want to support partial payments. And since the expected amount can change (via increase/decreaseExpectedAmount) I don't think we can store the expected amount on the contract.

@MantisClone
Copy link
Member Author

Despite the familiarity of the name "One Time Proxy", I don't think we should call it that, because we support partial payments meaning that a given proxy contract can be paid more than once. I prefer the name "SingleRequestProxy". I think it makes it clear that the Proxy is tied to a single request.

@MantisClone MantisClone assigned MantisClone and unassigned skiv71 Apr 9, 2024
@MantisClone MantisClone removed their assignment Apr 26, 2024
@MantisClone MantisClone changed the title Develop a PoC "One Time Proxy" payment smart contract that emits the paymentReference event in the receive() function Develop a PoC "SingleRequestProxy" payment smart contract that emits the paymentReference event in the receive() function Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Sprint Backlog
Development

No branches or pull requests

3 participants