Mock rep v2 in author profile #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yattias
approved these changes
Jun 17, 2024
yattias
reviewed
Jun 17, 2024
src/user/serializers.py
Outdated
| @@ -1050,6 +1050,7 @@ def get_coauthor(self, coauthor): | |||
| class DynamicAuthorProfileSerializer(DynamicModelFieldSerializer): | |||
| institutions = SerializerMethodField() | |||
| coauthors = SerializerMethodField() | |||
| reputations = SerializerMethodField() | |||
There was a problem hiding this comment.
Could we change name to reputation_list or a different name? I'm thinking we will also need a field called reputation to indicate what the user's rep is (atm it is decided it will be the highest value in that list: max_val(reputations)
yattias
reviewed
Jun 18, 2024
src/user/serializers.py
Outdated
| "hub_id": 1, | ||
| "hub_name": "Cell Biology", | ||
| "hub_slug": "slug-1", | ||
| "score": 1982000, |
There was a problem hiding this comment.
This value is greater than the top bin value?
There was a problem hiding this comment.
Will update the bins in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.