New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button Title Layout Clipping #1533
Comments
Hi @Brett-Best , We recently fixed this on main with |
Hey @louie-apple, when I pull the latest main in (same as release you mentioned) I now get:
|
It looks like |
Nonetheless, I just checked the catalog app using the reproduction steps in the video posted in the issue description and it still reproduces the exact same, so not fixed unfortunately. |
For the duplicate symbol issue happening here, our officially supported method of installing RK is through linking the project. You can find the info here: https://github.com/ResearchKit/ResearchKit#adding-the-researchkit-framework-to-your-app |
* Address issue where there was no option to "Save Results" if task is cancelled (Issue #1536/1540) * Address an issue where ORKTaskViewController setting tintColor on stepViewController views broke ORKStepViewController's addResult: * Fixed order issue of tone audiometry steps * Include missing ORKSpeechRecognition header export (Issue #1534) * Switch to contentEdgeInsets API in ORKContinueButton to fix an issue where button title wouldn't always fit onscreen (on iOS 16 during long press) (Issue #1533) * Remove min/max values for ORKCatalog "Numeric with Display Unit" * xcconfig file updates for version and driving ORKCatalog bundleID * Addressing compiler warnings * Added unit tests for init'ing taskViewController with restoration data * Adding task restoration feature to ORKCatalog's taskViewController presentation
Hi @Brett-Best, We recently pushed a new release, 2.2.9-dev (https://github.com/ResearchKit/ResearchKit/releases/tag/2.2.9-dev) on main. Would you please pull this release and see if it resolves your issue? |
Thank you, it fixes the issue! |
Using the latest ResearchKit (and the catalog project) from main (fc67cc9) I am seeing some issues when I press on the buttons at the bottom of the task view controller.
See video below for reproduction
https://user-images.githubusercontent.com/6104381/205573863-1499a564-4ebf-4799-9ecd-e6a756a704d4.mp4
If the video doesn’t play in browser, download it instead.
Tested using Xcode 14.1, iOS 16.1/16.2b4
The text was updated successfully, but these errors were encountered: