Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ORKTextChoiceOther.choice not working on iOS 14 #1429

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ORKTextChoiceOther.choice not working on iOS 14 #1429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions ResearchKit/Common/ORKChoiceViewCell.m
View file
Open in desktop
Expand Up @@ -179,29 +179,29 @@ - (void)setupContainerView {
if (!_containerView) {
_containerView = [UIView new];
}
[self addSubview:_containerView];
[self.contentView addSubview:_containerView];
}

- (void)addContainerViewToSelfConstraints {
[_containerConstraints addObjectsFromArray:@[
[NSLayoutConstraint constraintWithItem:_containerView
attribute:NSLayoutAttributeTop
relatedBy:NSLayoutRelationEqual
toItem:self
toItem:self.contentView
attribute:NSLayoutAttributeTop
multiplier:1.0
constant:0],
[NSLayoutConstraint constraintWithItem:_containerView
attribute:NSLayoutAttributeLeft
relatedBy:NSLayoutRelationEqual
toItem:self
toItem:self.contentView
attribute:NSLayoutAttributeLeft
multiplier:1.0
constant:_leftRightMargin],
[NSLayoutConstraint constraintWithItem:_containerView
attribute:NSLayoutAttributeRight
relatedBy:NSLayoutRelationEqual
toItem:self
toItem:self.contentView
attribute:NSLayoutAttributeRight
multiplier:1.0
constant:-_leftRightMargin]
Expand Down Expand Up @@ -291,7 +291,7 @@ - (void)setupConstraints {
[self addDetailLabelConstraints];
[self addCheckViewToContainerViewConstraints];
[self addContainerViewBottomConstraint];
[_containerConstraints addObject:[NSLayoutConstraint constraintWithItem:self
[_containerConstraints addObject:[NSLayoutConstraint constraintWithItem:self.contentView
attribute:NSLayoutAttributeBottom
relatedBy:NSLayoutRelationEqual
toItem:_containerView
Expand Down