Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify how cite-as and Signposting should be used #255

Merged
merged 4 commits into from May 17, 2023
Merged

Conversation

stain
Copy link
Contributor

@stain stain commented May 11, 2023

This fixes #239 as re-opened by @ptsefton to specify cite-as as well as identifier in the case of a persistent identifier.

I also added the profile definition links as part of #251. I think some of these can be removed as they are not referenced in spec.

The Signposting bit should later be consolidated with the "How to retrieve a crate" currently in profiles.md to fix #228 #160.

Catering Peter's question on textual citation I added description on the PropertyValue -- not sure what you think about that.

@stain stain mentioned this pull request May 17, 2023
29 tasks
@stain
Copy link
Contributor Author

stain commented May 17, 2023

@ptsefton do you think this is OK to add, or shall we delay it past 1.2? Can split it so the [definition] links can be added only, but I heard you wanted to add cite-as as well

@stain stain added this to the RO-Crate 1.2 milestone May 17, 2023
@stain stain added this to Under discussion/review in RO-Crate specifications May 17, 2023
Copy link
Contributor

@ptsefton ptsefton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine

@ptsefton ptsefton merged commit eeb6c49 into master May 17, 2023
RO-Crate specifications automation moved this from Under discussion/review to Done May 17, 2023
@stain stain deleted the cite-as branch May 18, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Use Case: How to get the contents of a RO as a zip file? BUG: Error in @context cite-as does not resolve
2 participants