Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ShEx validation method #17

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

WIP: ShEx validation method #17

wants to merge 32 commits into from

Conversation

stain
Copy link
Contributor

@stain stain commented Mar 8, 2023

Work in progress that adds ShEx validation of Workflow Run crates.

runcrate validate tests/data/profile-examples/process-ex1/
/home/stain/miniconda3/envs/validate/lib/python3.11/site-packages/rdflib_jsonld/__init__.py:9: DeprecationWarning: The rdflib-jsonld package has been integrated into rdflib as of rdflib==6.0.0.  Please remove rdflib-jsonld from your project's dependencies.
  warnings.warn(
Validating RO-Crate tests/data/profile-examples/process-ex1
   OK File existence
   OK File size
   OK Metadata file existence
   OK Json check
   OK Json-ld check
   OK File descriptor check
ERROR Direct property check:
      Semantic Error: datePublished of Direct Property ./ is not in ISO 8601 date format or not Provided
   OK Referencing check
   OK Encoding check
   OK Web-based data entity check
   OK Person entity check
   OK Organization entity check
   OK Contact information check
   OK Citation property check
   OK Publisher property check
   OK Funder property check
   OK Licensing property check
   OK Places property check
   OK Time property check
ERROR Scripts and workflow check:
      Semantic Error: Scripts and Workflow is Wrong
Validating against Process Run profile
CONFORMS

The initial checks on the RO-Crate are from https://github.com/ResearchObject/ro-crate-validator-py but may not be always appropriate. E.g. above it should skip the Scripts-check when it is a process crate profile being tested.

Note that so far only process run profile is complete. I've taken the stand that SHOULDs are required by the validation, as breaking a should is something done knowingly. However this may not be appropriate for checking the inherted profiles.

The remaining workflow/provenance profiles are not finished, as I think I need to add a second ComputationalWorkflow bioschemas profile that is currently just implied.

@stain stain marked this pull request as draft March 8, 2023 01:38
@simleo
Copy link
Collaborator

simleo commented Mar 21, 2023

See workflowhub-eu/about#46 re: ComputationalWorkflow

setup.cfg Outdated Show resolved Hide resolved
@stain stain changed the title WIP: ShEx WIP: ShEx validation method Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants