Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #4

Open
Qqwy opened this issue Jul 17, 2018 · 1 comment
Open

Refactoring #4

Qqwy opened this issue Jul 17, 2018 · 1 comment

Comments

@Qqwy
Copy link
Contributor

Qqwy commented Jul 17, 2018

Currently, the ChatChannel and the Planga.Chat context are not as beautiful as they could be :-) .
@Qqwy
Copy link
Contributor Author

Qqwy commented Oct 11, 2018

FYI, this is about 66% done.

the ChatChannel is already a lot nicer, having all relevant parts split off into a Planga.Connection concern, meaning that we can in the future easily adapt other types of connections (such as direct POST requests from servers that want to create a single message).

It's mostly the database-stuff (The Planga.Chat context) that still can be cleaned up. It would be nice if we can completely abstract away what database is used, using a nice dependency inversion behaviour. (We want to step off from Ecto for the database-related stuff as well because the database(s) we'll be using will probably be very far distanced from relational ones).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Qqwy