Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant #7: Clear step-by-step instructional guide for users #7

Open
ghost opened this issue Jul 13, 2020 · 16 comments
Open

Grant #7: Clear step-by-step instructional guide for users #7

ghost opened this issue Jul 13, 2020 · 16 comments
Assignees
Labels
approved The grant has been approved

Comments

@ghost
Copy link

ghost commented Jul 13, 2020

Grant #7
This is a proposal for a Resistance Support task:
An API developer is required to test the Resistance RestAPI and create a clear step-by-step instructional guide for users.
With a functioning RestAPI, users will be able to tap into, and potentially provide more liquidity to ResDEX and could earn a small arbitrage by doing so.
If this proposal is approved by the Masternode voters, then the community member who performs this task will be issued a grant from the developer's fund (from the 10% reward splitting).
The amount of RES granted will be: 175,877
A simple majority will be used to approve or reject this proposal. At least one Masternode must vote on an issue for it to be approved. To apply with a proposal email admin [at] resistance.io and include your GitHub username in your email so our admins can verify your development record. For information on how to cast your vote, please refer to the README in this repository.
Voting opens immediately and will close on: 22nd July 2020, developers have until 1st August to send in proposals if the grant is approved.

@ghost ghost closed this as completed Jul 13, 2020
@ghost ghost reopened this Jul 13, 2020
@ghost ghost added the voting The grant is currently being voted on label Jul 13, 2020
@ghost
Copy link
Author

ghost commented Jul 13, 2020

-----BEGIN VOTE-----
Y:7:r13fwb1K9sK6YYoTf22c6CJPxequKMxcA7L:1594661246:Hy3POXUTBQ2wOFTQJwIXJjAMAw1y0QBmGRhff9+iCz+fJ+TJlMKg29B7YFExJ15dK3H+ENXtSZ67klYoieCK6iE=
-----END VOTE-----

@MEtoolel
Copy link

Y:7:r18fiaRwkHZNy2n37wRLrH4SuFTfJJCS2HV:1594695743:IBYYg1V+xoZJ3sj+qIAo1RyglO9GDH0xzLym7zUIYWshQmsqjIyLHIrcwOKgUFD8Rsf7ZrSJEJJDWcnM/5ItRdo=

@whiteknightrader
Copy link

-----BEGIN VOTE-----
Y:7:r1B5YJxB8CGjmmXhBtEmAZd25QdvKEGNgxq:1594751752:H1V/B8o7/EsX8KYGvk3WLr3y7t2QBuekG9GooMeWaFwOWhHvGdYqTw6K9mdToiKHdsCsvdmLzKHVl8T9MYTWRNM=
-----END VOTE-----

@ian-p-johnson
Copy link

This will involve testing, documenting and possibly FIXING the API in the DEX (given that the API has zero documentation it can only be discerned from sources - and changes will likely be required) - the scope of the task is too large for the simple spec/reward above. There is no way to test the DEX safely without disposable/test assets configured into the DEX which requires new assets and DEX configuration as well as setup of relevant Electrum servers. It is far from trivial.

Also needs a clear definition of what entails successful completion - if the underlying DEX does not work but the REST API does work - will the reward be made ?

The scope of the work needs defining with far more detail

@ghost
Copy link
Author

ghost commented Jul 15, 2020

Ian, this is not something that a community dev does alone nor the previous tasks. There is a common group with all resistance devs and there numerous conversations as things progress . I have asked Luke to clarify your points but for me it is clear the task. If resdex does not work this task will point out the issues and that will become next task. However, I reiterate my point that we work with the devs as we progress , it is not a tachaaaan this is the work! Give me the money. You can ask them the whole time (if they are available)

@ian-p-johnson
Copy link

ian-p-johnson commented Jul 20, 2020

A better description would be series of Grants that MIGHT go as follows: (IN ORDER)

  1. "Establish, build some simple API access to RESDEX and ascertain scope of potential capabilities" (needs RESDEX server component source)
  2. "Ascertain available API, test and document - fixing problems where required" (Requires free to transact free to own alternate assets configured into DEX)
  3. "Make changes to GUI to reflect operations invoked in API " (Needs RESDEX GUI sources)

Specifying a series of grants for this would entail specifying a dependence on sources of RESDEX for which there is no timescale, or even stated intention - in fact i would say that the FIRST step would be access as there is no way to work out what the API is without access to the sources as it is a MODIFIED Komodo MM2 API - the differences are crucial enough to impede successful testing and documentation.

A later step would likely require access to the DEX GUI sources to ensure that operations in the API are reflected in the GUI correctly

Granting proposals which cannot be serviced because of inadequate access to code would be entirely pointless and meaningless.

This is my opinion of the prerequisites

@hamiltonga
Copy link

-----BEGIN VOTE-----
Y:7:r18Dsyhhr6GcQJp8SxGqbtYZNCDaxm8DuN6:1595417966:IISAIYM0eQT2aUQbun8zfoEj8pNiZvNOJRFR2TQjV6yQJepsyqauo2P10hRniV9KJn5CckU07LPgUA2x49R9cNY=
-----END VOTE-----

@ghost
Copy link
Author

ghost commented Jul 23, 2020

The votes have been tallied and the results are in favor of accepting this proposal.

cat list_of_votes7.txt
-----BEGIN VOTE-----
Y:7:r13fwb1K9sK6YYoTf22c6CJPxequKMxcA7L:1594661246:Hy3POXUTBQ2wOFTQJwIXJjAMAw1y0QBmGRhff9+iCz+fJ+TJlMKg29B7YFExJ15dK3H+ENXtSZ67klYoieCK6iE=
-----END VOTE-----
-----BEGIN VOTE-----
Y:7:r18fiaRwkHZNy2n37wRLrH4SuFTfJJCS2HV:1594695743:IBYYg1V+xoZJ3sj+qIAo1RyglO9GDH0xzLym7zUIYWshQmsqjIyLHIrcwOKgUFD8Rsf7ZrSJEJJDWcnM/5ItRdo=
-----END VOTE-----
-----BEGIN VOTE-----
Y:7:r1B5YJxB8CGjmmXhBtEmAZd25QdvKEGNgxq:1594751752:H1V/B8o7/EsX8KYGvk3WLr3y7t2QBuekG9GooMeWaFwOWhHvGdYqTw6K9mdToiKHdsCsvdmLzKHVl8T9MYTWRNM=
-----END VOTE-----
-----BEGIN VOTE-----
Y:7:r18Dsyhhr6GcQJp8SxGqbtYZNCDaxm8DuN6:1595417966:IISAIYM0eQT2aUQbun8zfoEj8pNiZvNOJRFR2TQjV6yQJepsyqauo2P10hRniV9KJn5CckU07LPgUA2x49R9cNY=
-----END VOTE-----

tr -d '\r' < list_of_votes7.txt | grep -v "BEGIN VOTE" | grep -v "END VOTE" | ./verify.sh 7
jq installed... proceeding
curl installed... proceeding


| Final Tally for GitHub Issue: 7

YES: 4
NO: 0

This grant is approved.
Developers have until 1st August to send in proposals
The amount of RES granted will be: 175,877
Once the terms of the proposal are met, we will release the RES reward from the dev fund
Look forward to your proposals
Thank you!

@ghost ghost added approved The grant has been approved and removed voting The grant is currently being voted on labels Jul 23, 2020
@whiteknightrader
Copy link

i can try this. but as i have already committed on grant 2 and 8. i will finish those and try this. if any devs takes this grant before that.., no issues on my part.

@ghost ghost assigned ghost and unassigned ghost Aug 4, 2020
@cryptotrader2020
Copy link

Hi,
Please can you assign this grant to me.
BR
Cryptotrader2020

@ghost ghost assigned ghost and cryptotrader2020 and unassigned ghost Aug 4, 2020
@ghost
Copy link
Author

ghost commented Aug 4, 2020

Hi,
Please can you assign this grant to me.
BR
Cryptotrader2020

Hi You have just been assigned. All yours!!! Good luck!!!

@ian-p-johnson
Copy link

As with grant #8 - do we get to review, comment on and test the work before the "terms of the proposal are met" ?

@ghost
Copy link
Author

ghost commented Aug 9, 2020

The resistance team is in charge in reviewing and approval the work done and decide whether the developer gets the grant

@ian-p-johnson
Copy link

But there should be some concrete result - a deliverable - or will it just be a tick on a box

@ghost
Copy link
Author

ghost commented Aug 15, 2020

Again, please let them tick the boxes .

@ghost
Copy link
Author

ghost commented Aug 15, 2020

And do not hesitate that if @whiteknightrader does the job he will do his best . In fact, we are ticking the boxes for them so this project becomes what it truly was aimed for: a decentralised project for the community. We are more than capable to turn this project around . I am 100% sure but when we can manage it and make decisions towards that goal. So, Anthony should make clear WHEN this will be fully decentralised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The grant has been approved
Projects
None yet
Development

No branches or pull requests

5 participants